[stdlib] Use const for graphemeBreakProperties
#40711
Conversation
|
|
||
| static __swift_uint32_t _swift_stdlib_graphemeBreakProperties[621] = { | ||
| static const __swift_uint32_t _swift_stdlib_graphemeBreakProperties[610] = { |
There was a problem hiding this comment.
This is the only change I wanted to make (adding the const keyword) but the gen-unicode-data package seems outdated — I had to rename input/output paths, etc. (And the generated data is different.)
There was a problem hiding this comment.
You can't say GRAPHEME_BREAK_DATA_COUNT there, I take it, instead of repeating the magic number?
There was a problem hiding this comment.
You can't say
GRAPHEME_BREAK_DATA_COUNTthere, I take it, instead of repeating the magic number?
If the array is declared with a size, but its initializer list contains fewer elements, the rest will be zero initialized.
So the safest way might be to declare it with empty [] brackets, and then static_assert with the expected size and the sizeof operator (or the std::extent value).
(But this is probably unnecessary for auto-generated declarations.)
There was a problem hiding this comment.
Oh it seems I forgot to push my changes to this target. If you want, I can push those so that this is just the const addition?
There was a problem hiding this comment.
If you want, I can push those so that this is just the const addition?
It might be easier if you add the const keyword yourself, when pushing those changes. If so, this PR can be closed.
|
Closing due to #40746. |
No description provided.