-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[stdlib] Implement the Indic grapheme breaking rules #40746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please smoke test |
@swift-ci please benchmark |
Performance (x86_64): -O
Code size: -OPerformance (x86_64): -Osize
Code size: -OsizePerformance (x86_64): -Onone
Code size: -swiftlibsHow to read the dataThe tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.If you see any unexpected regressions, you should consider fixing the Noise: Sometimes the performance results (not code size!) contain false Hardware Overview
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick pass over LGTM, but I haven't looked too deeply at checkIfInIndicSequence
. IIRC, that's similar to other kinds of scan-backwards checks we have for regional indicators. Is the logic sufficiently similar that we could share the algorithm, or is it fairly distinct?
They're both similar in that they need to walk backwards, but the logic afterwards is fairly distinct. We could parameterize the logic and share a backwards walker if we wanted. |
[stdlib] Implement the Indic grapheme breaking rules
This implements the CLDR Indic grapheme sequences rule in the stdlib that was also handled by ICU. The rule can be found here: https://github.com/unicode-org/cldr/tree/main/common/properties/segments