Give a proper error when a member type is inaccessible. #4105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't yet cover top-level types or top-level non-type values, but it's a start. Part of rdar://problem/27663403. (cherry picked from commit 8d95352)
|
@slavapestov, @jckarter, or @milseman, mind reviewing this? @swift-ci Please test |
|
This isn't my area of expertise—would this have any chance of the inaccessible members influencing overload resolution? |
|
Good question. No, for two reasons: (1) this only occurs in an error path, and (2) we don't even use the types we find, because otherwise we get further errors downstream that don't really add anything. |
|
Cool, (1) was what I thought, but I wanted to double-check. LGTM. |
kateinoigakukun
pushed a commit
that referenced
this pull request
Aug 31, 2022
Reduce WASI include path diff with upstream `main`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
privatehas changed. This patch adds that for qualified lookup.(not reviewed yet)@jckarterBefore merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
A smoke test on macOS does the following:
device standard libraries are not built.
version of these tests are not run.
A smoke test on Linux does the following:
tests are not run.
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.