[CMake] set target architecture for Darwin idiomatically #41059
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were setting `-arch` explicitly and unsetting `CMAKE_OSX_ARCHITECTURES`; however this approach does not work when building on Apple Silicon, since in there CMake 3.19+ enforces a default value (https://gitlab.kitware.com/cmake/cmake/-/merge_requests/5291/diffs), and this would result in the inability to compile code for x86_64. This is a similar approach used for stdlib targets in swiftlang#38415 Addresses rdar://88100025
|
@swift-ci please test |
|
@swift-ci please test Apple Silicon |
compnerd
approved these changes
Jan 28, 2022
|
Build failed |
|
@swift-ci please test macOS |
CodaFi
approved these changes
Jan 28, 2022
|
Build failed |
|
@swift-ci please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were setting
-archexplicitly and unsettingCMAKE_OSX_ARCHITECTURES; however this approach does not work whenbuilding on Apple Silicon, since in there CMake 3.19+ enforces a default
value
(https://gitlab.kitware.com/cmake/cmake/-/merge_requests/5291/diffs),
and this would result in the inability to compile code for x86_64.
This is a similar approach used for stdlib targets in #38415
Addresses rdar://88100025