Override -arch For Stdlib Targets #41119
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Apple Silicon hosts, CMake defaults OSX_ARCHITECTURES to the host arch. When the cmake later explicitly provides -arch, clang interprets this as a directive to emit fat object files. When we go to lipo them together, the host arches in the object files collide and the build goes kaput.
CodaFi
commented
Feb 1, 2022
| @@ -1203,6 +1202,10 @@ function(add_swift_target_library_single target name) | |||
|
|
|||
| list(APPEND library_search_directories "${SWIFT_SDK_${sdk}_ARCH_${arch}_PATH}/usr/lib/swift") | |||
|
|
|||
| # Override -arch on macOS. This is crucial for Apple Silicon, where CMake forces | |||
| # the *host* architecture to appear as the argument to -arch otherwise. | |||
| set_property(TARGET ${target} PROPERTY OSX_ARCHITECTURES "${SWIFTLIB_SINGLE_ARCHITECTURE}") | |||
There was a problem hiding this comment.
@edymtt I'm not sure if this is the appropriate place to put it, but we aren't passing target down to _add_target_variant_c_compile_link_flags AFAICT so it's a bit tough to move there.
|
@swift-ci test |
|
Eric has a better answer here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Apple Silicon hosts, CMake defaults OSX_ARCHITECTURES to the
host arch. When our cmake later explicitly provides -arch, clang
interprets two -arch flags as a directive to emit fat object files. When we go
to lipo them together, the host arches in the object files collide
and the build goes kaput.
In the same vein as #41059, stamp out the last place we were explicitly passing -arch.