[5.6][SymbolGraph] consider underscored symbols as private if they're internal
#41161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #41156
Explanation: Symbols that begin with an underscore are always treated as
internalwhen generating a symbol graph. However, there are more nuanced semantics for them: Symbols that are alreadyinternalor less should be treated asprivatefor the purposes of access level filtering. This PR introduces this logic.Scope: This change is isolated to SymbolGraphGen, and should only affect symbol graphs which are generated with a
-minimum-access-levelofinternalor less.Issue: rdar://86294802
Risk: Low. This only affects SymbolGraphGen, and does not affect anything that happens during a regular compilation.
Testing: The lit test
SymbolGraph/Symbols/SkipsPublicUnderscorewas updated to verify the new logic.