SR-15910: C++ Interop Getting Started Documentation #41580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cabmeurer
force-pushed
the
SR-15910-C++-Interop-Getting-Started-Documentation
branch
3 times, most recently
from
705448f to
0911e7d
Compare
|
here is the repo i made to show these examples: https://github.com/cabmeurer/CxxInterop_Examples |
zoecarver
reviewed
Feb 28, 2022
|
Thank you for the patch. This looks really great! I have a few comments, but they're all pretty minor. This mostly looks good. Can't wait to land it. Until you have commit access, you won't be able to trigger swift-ci. You can just ask one of us to do it. I will run the bots once you address my comments above :) |
cabmeurer
force-pushed
the
SR-15910-C++-Interop-Getting-Started-Documentation
branch
2 times, most recently
from
419018b to
879671a
Compare
zoecarver
reviewed
Feb 28, 2022
cabmeurer
force-pushed
the
SR-15910-C++-Interop-Getting-Started-Documentation
branch
2 times, most recently
from
ec3c9fd to
a08f76b
Compare
cabmeurer
force-pushed
the
SR-15910-C++-Interop-Getting-Started-Documentation
branch
3 times, most recently
from
2a5e901 to
77b75a4
Compare
zoecarver
approved these changes
Feb 28, 2022
cabmeurer
force-pushed
the
SR-15910-C++-Interop-Getting-Started-Documentation
branch
2 times, most recently
from
6dc023c to
2cab173
Compare
cabmeurer
force-pushed
the
SR-15910-C++-Interop-Getting-Started-Documentation
branch
from
2cab173 to
7e89097
Compare
zoecarver
approved these changes
Feb 28, 2022
|
@swift-ci please smoke test. |
cabmeurer
commented
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a document specific to getting started for utilizing C++ interop.
The examples provided are Add C++ to an xcode project, Creating a Swift Package, and Building with CMake.