Skip to content

[Distributed] better diagnostics for missing actor system typealias #41602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2022

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Mar 1, 2022

Thank you @kavon for reminding me about the fact that the failure is pretty ugly.

Resolves rdar://89585848 Tailored diagnostic for DA conformance fail

@ktoso ktoso force-pushed the wip-better-error branch from 5061820 to 02c2c96 Compare March 1, 2022 12:42
@ktoso ktoso force-pushed the wip-better-error branch from 02c2c96 to 4987ec6 Compare March 1, 2022 12:43
@ktoso ktoso added the distributed Feature → concurrency: distributed actor label Mar 1, 2022
@ktoso
Copy link
Contributor Author

ktoso commented Mar 1, 2022

@swift-ci please smoke test

@ktoso
Copy link
Contributor Author

ktoso commented Mar 7, 2022

Will rebase this after #41616 lands

@ktoso ktoso force-pushed the wip-better-error branch from 4987ec6 to 6524a7e Compare March 11, 2022 02:07
@ktoso ktoso force-pushed the wip-better-error branch from 6524a7e to f2d60e1 Compare March 11, 2022 02:10
@ktoso
Copy link
Contributor Author

ktoso commented Mar 11, 2022

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit a024e8f into swiftlang:main Mar 11, 2022
@ktoso ktoso deleted the wip-better-error branch March 11, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distributed Feature → concurrency: distributed actor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants