[Distributed] Reimplement distributed call thunks completely in AST #41616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
force-pushed
the
wip-allow-distributed-in-protocols-hop-to-ast
branch
from
a52448d to
a98d34f
Compare
ktoso
force-pushed
the
wip-allow-distributed-in-protocols-hop-to-ast
branch
from
9ab487f to
d8afe3f
Compare
|
@swift-ci please smoke test |
|
@swift-ci please build toolchain |
|
@swift-ci please smoke test |
ktoso
force-pushed
the
wip-allow-distributed-in-protocols-hop-to-ast
branch
from
883b0f5 to
5c09384
Compare
|
@swift-ci please smoke test |
|
@swift-ci please build toolchain |
|
resolves rdar://84054772 |
|
The failures are some linux only thing, we'll need to investigate... |
This was referenced Mar 8, 2022
…ibuted actor - Classes have specialized method on their declarations - Archetypes and existentials check their conformances for presence of `DistributedActor` protocol.
…extensions `getConcreteReplacementForProtocolActorSystemType` should use `getSelfClassDecl` otherwise it wouldn't be able to find actor if the member is declared in an extension.
[PreChecker] LookupDC might be null, so account for that
… section test-cases
ktoso
force-pushed
the
wip-allow-distributed-in-protocols-hop-to-ast
branch
from
ceddca8 to
3c41b0a
Compare
|
@swift-ci please smoke test and merge |
xedin
approved these changes
Mar 10, 2022
| AbstractFunctionDecl *ASTContext::getRemoteCallOnDistributedActorSystem( | ||
| NominalTypeDecl *actorOrSystem, bool isVoidReturn) const { | ||
| assert(actorOrSystem && "distributed actor (or system) decl must be provided"); | ||
| const NominalTypeDecl *system = actorOrSystem; |
There was a problem hiding this comment.
I think you should drop const here.
… thunk test-cases
|
@swift-ci please smoke test linux |
|
Addressed comments and XFAILed a few linux tests because I really want to land this PR, it's holding up a lot of the other ones. Will fix the linux tests ASAP though, it is just mangling fixes i think. rdar://90078069 |
|
@swift-ci please smoke test and merge |
ktoso
force-pushed
the
wip-allow-distributed-in-protocols-hop-to-ast
branch
from
3e1819b to
b91905f
Compare
ktoso
force-pushed
the
wip-allow-distributed-in-protocols-hop-to-ast
branch
from
b91905f to
6440861
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies a ton of things but not complete yet.