Skip to content

[Distributed] Fix generic actors and distributed funcs returning those generics #41747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 25, 2022
Merged

[Distributed] Fix generic actors and distributed funcs returning those generics #41747

merged 3 commits into from
Mar 25, 2022

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Mar 9, 2022 •
edited
Loading

Depends on #41616

The actual fix: 5c54ad2

Once we merge #41616 I'll rebase this. Done

Resolves rdar://84458365

@ktoso ktoso force-pushed the wip-generic-return branch 2 times, most recently from 9d2f102 to 5c54ad2 Compare March 9, 2022 13:58
@ktoso ktoso added the distributed Feature → concurrency: distributed actor label Mar 9, 2022
@ktoso ktoso force-pushed the wip-generic-return branch 2 times, most recently from b7f2c32 to 854f3e1 Compare March 10, 2022 15:21
@ktoso
Copy link
Contributor Author

ktoso commented Mar 10, 2022

@swift-ci please smoke test

@ktoso ktoso force-pushed the wip-generic-return branch from 854f3e1 to 62c37c3 Compare March 11, 2022 03:19
xedin
xedin reviewed Mar 11, 2022
View reviewed changes
@ktoso
Copy link
Contributor Author

ktoso commented Mar 11, 2022

@swift-ci please smoke test

@ktoso
Copy link
Contributor Author

ktoso commented Mar 11, 2022

This actually still fails in SIL handling in the init/deinit when the ACTOR is generic. I'll handle this separately.

@ktoso
Copy link
Contributor Author

ktoso commented Mar 11, 2022 •
edited
Loading

Okey this actually still has missing symbols that I noticed that I added runtime tests... I'll give it a sleep tonight but will try to make progress tomorrow

Undefined symbols for architecture arm64:
  "associated conformance descriptor for _Distributed.DistributedActorSystem._Distributed.DistributedActorSystem.ActorID: Swift.Encodable", referenced from:
      l_got.associated conformance descriptor for _Distributed.DistributedActorSystem._Distributed.DistributedActorSystem.ActorID: Swift.Encodable in FakeDistributedActorSystems-89b96e.o
  "associated conformance descriptor for _Distributed.DistributedActorSystem._Distributed.DistributedActorSystem.ActorID: Swift.Decodable", referenced from:
      l_got.associated conformance descriptor for _Distributed.DistributedActorSystem._Distributed.DistributedActorSystem.ActorID: Swift.Decodable in FakeDistributedActorSystems-89b96e.o
  "(extension in _Distributed):_Distributed.DistributedActor.init(from: Swift.Decoder) throws -> A", referenced from:
      protocol witness for Swift.Decodable.init(from: Swift.Decoder) throws -> A in conformance main.Greeter : Swift.Decodable in main in distributed_actor_func_calls_remoteCall_genericFunc-a4d98b.o
  "(extension in _Distributed):_Distributed.DistributedActor.encode(to: Swift.Encoder) throws -> ()", referenced from:
      protocol witness for Swift.Encodable.encode(to: Swift.Encoder) throws -> () in conformance main.Greeter : Swift.Encodable in main in distributed_actor_func_calls_remoteCall_genericFunc-a4d98b.o
  "base conformance descriptor for _Distributed.DistributedActor: Swift.Encodable", referenced from:
      l_got.base conformance descriptor for _Distributed.DistributedActor: Swift.Encodable in distributed_actor_func_calls_remoteCall_genericFunc-a4d98b.o
  "base conformance descriptor for _Distributed.DistributedActor: Swift.Decodable", referenced from:
      l_got.base conformance descriptor for _Distributed.DistributedActor: Swift.Decodable in distributed_actor_func_calls_remoteCall_genericFunc-a4d98b.o
ld: symbol(s) not found for architecture arm64

@ktoso
Copy link
Contributor Author

ktoso commented Mar 16, 2022

Note to self: this one over to @DougGregor to see if he can figure it out

@DougGregor
Copy link
Member

@swift-ci please smoke test

@ktoso ktoso force-pushed the wip-generic-return branch from 7700233 to e8a386f Compare March 18, 2022 23:36
@ktoso
Copy link
Contributor Author

ktoso commented Mar 21, 2022

@swift-ci please smoke test Linux

@xedin xedin mentioned this pull request Mar 24, 2022
Merged
@xedin xedin force-pushed the wip-generic-return branch from e8a386f to cecaa8d Compare March 25, 2022 00:11
@ktoso ktoso force-pushed the wip-generic-return branch from cecaa8d to 9220c47 Compare March 25, 2022 02:37
@ktoso
Copy link
Contributor Author

ktoso commented Mar 25, 2022

Thank you a lot @xedin! 🙇 Looking good, I cleaned up a bit and added a minor test just to be sure remote call was fine as well (it was).

@swift-ci please smoke test and merge

xedin
xedin reviewed Mar 25, 2022
View reviewed changes
@ktoso ktoso force-pushed the wip-generic-return branch from 9220c47 to 466c633 Compare March 25, 2022 08:12
@ktoso
Copy link
Contributor Author

ktoso commented Mar 25, 2022

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit 048e41e into swiftlang:main Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xedin xedin xedin left review comments

Assignees
No one assigned
Labels
distributed Feature → concurrency: distributed actor help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ktoso @DougGregor @xedin @swift-ci