[Serialization] Recover from failures under AnyObjectLookup #41647
Conversation
|
@swift-ci Please smoke test |
|
@beccadax Thank you for the concise reproducer! |
|
CC @nkcsgexi since this is close to something you're investigating. |
| auto declOrError = getDeclChecked(item.second); | ||
| if (!declOrError) { | ||
| if (!getContext().LangOpts.EnableDeserializationRecovery) | ||
| fatal(declOrError.takeError()); | ||
| consumeError(declOrError.takeError()); | ||
| continue; | ||
| } |
There was a problem hiding this comment.
We have this block in... quite a few places now. Should we abstract it into another method? Probably fine to do in a follow up either way.
There was a problem hiding this comment.
We could use an alternative to getDeclChecked that drops the error. It could clean up these call sites a bit and we could use it to apply more precise filtering of the errors, to drop only XRef/implementation-only errors for example.
xymus
force-pushed
the
recover-from-anyobject-lookup
branch
from
a5a592d to
694b629
Compare
|
Updated to use the mock-sdk and fix other OSes. @swift-ci Please smoke test |
rdar://89494507
xymus
force-pushed
the
recover-from-anyobject-lookup
branch
from
694b629 to
4d75242
Compare
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test macOS |
rdar://89494507