Skip to content

[Distributed] Offer LocalTestingDistributedActorSystem #41756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 16, 2022

Conversation

yim-lee
Copy link
Contributor

@yim-lee yim-lee commented Mar 9, 2022

Add local-only actor system LocalTestingDistributedActorSystem to make code and tutorial development easier.

rdar://89580224

@yim-lee
Copy link
Contributor Author

yim-lee commented Mar 9, 2022

@ktoso Please review

Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good :) Need to figure out what locks we can use here to make it threadsafe...

@ktoso ktoso added the distributed Feature → concurrency: distributed actor label Mar 9, 2022
@yim-lee yim-lee force-pushed the distributed/loccal-actor-system branch from 524e054 to 3f3c9c2 Compare March 10, 2022 00:56
@yim-lee yim-lee changed the title Offer LocalTestingDistributedActorSystem [Distributed] Offer LocalTestingDistributedActorSystem Mar 10, 2022
Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We need to make it thread safe and we're good here :)

@yim-lee yim-lee force-pushed the distributed/loccal-actor-system branch 2 times, most recently from d3d98e1 to 547bf8e Compare March 10, 2022 20:32
@yim-lee yim-lee requested a review from ktoso March 10, 2022 20:34
@yim-lee yim-lee force-pushed the distributed/loccal-actor-system branch from 547bf8e to ec2fa76 Compare March 10, 2022 23:17
@ktoso
Copy link
Contributor

ktoso commented Mar 15, 2022

#41804 was fixed so we can now use the any spelling

@yim-lee yim-lee force-pushed the distributed/loccal-actor-system branch from 1e70364 to b001d5b Compare March 15, 2022 19:34
@yim-lee
Copy link
Contributor Author

yim-lee commented Mar 15, 2022

@swift-ci please smoke test

@ktoso
Copy link
Contributor

ktoso commented Mar 15, 2022

Not sure why I can't PR into your branch, but here's a minor patch that'll make us able ot merge this ktoso@a49310b

Thanks a lot @yim-lee !

@yim-lee
Copy link
Contributor Author

yim-lee commented Mar 15, 2022

Thanks @ktoso. cherry-picked.

@swift-ci please smoke test

// UNSUPPORTED: use_os_stdlib
// UNSUPPORTED: back_deployment_runtime

import _Distributed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sadly gotta test this all again since module name change

@ktoso
Copy link
Contributor

ktoso commented Mar 16, 2022

@swift-ci please smoke test and merge

@swift-ci swift-ci merged commit fcde683 into swiftlang:main Mar 16, 2022
@yim-lee yim-lee deleted the distributed/loccal-actor-system branch March 17, 2022 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distributed Feature → concurrency: distributed actor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants