Skip to content

[Parser] Support 'any' type in SwiftSyntax #41804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Mar 14, 2022

Previously, SwiftSyntax wasn’t able to parse 'any' types. Add support for them now.

@hborla Is there a more generic name for the 'some' or 'any' types? I went with SomeOrAnyType for now but if there’s a better name, I’d like to change it.

rdar://90077430

@hborla
Copy link
Member

hborla commented Mar 14, 2022

Is there a more generic name for the 'some' or 'any' types? I went with SomeOrAnyType for now but if there’s a better name, I’d like to change it.

There isn't one anywhere in the code base yet, but we could invent one. Maybe something like ConstrainedSugarType?

Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix, this unblocks some of our code which wanted to use the proper any Something :)

@ahoppen ahoppen force-pushed the pr/swiftsyntax-any-type branch from 49e7f06 to f4f29e4 Compare March 15, 2022 09:51
@ahoppen
Copy link
Member Author

ahoppen commented Mar 15, 2022

There isn't one anywhere in the code base yet, but we could invent one. Maybe something like ConstrainedSugarType?

Lacking any better ideas, I adopted the name.

Previously, SwiftSyntax wasn’t able to parse 'any' types. Add support for them now.

rdar://90077430
@ahoppen ahoppen force-pushed the pr/swiftsyntax-any-type branch from f4f29e4 to 7a1792a Compare March 15, 2022 09:52
@ahoppen
Copy link
Member Author

ahoppen commented Mar 15, 2022

swiftlang/swift-syntax#369

@swift-ci Please smoke test

@ahoppen
Copy link
Member Author

ahoppen commented Mar 15, 2022

swiftlang/swift-syntax#369

@swift-ci Please smoke test macOS

@ahoppen ahoppen merged commit 1f629f7 into swiftlang:main Mar 15, 2022
@ahoppen ahoppen deleted the pr/swiftsyntax-any-type branch March 15, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants