[CodeCompletion] Migrate ForEachSequence and PostfixExprBeginning to solver-based #41886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
pr/migrate-foreachsequence-postfixexprbeginning-solver-based
branch
2 times, most recently
from
6edfc49 to
dca5651
Compare
This was referenced Mar 21, 2022
ahoppen
force-pushed
the
pr/migrate-foreachsequence-postfixexprbeginning-solver-based
branch
from
dca5651 to
48e8a13
Compare
xedin
approved these changes
Mar 22, 2022
ahoppen
force-pushed
the
pr/migrate-foreachsequence-postfixexprbeginning-solver-based
branch
2 times, most recently
from
3c8a9fb to
be35e75
Compare
This fixes a performance problem where we were sometimes reporting >1000 solutions but all the relevant parameters of the result were equal.
ahoppen
force-pushed
the
pr/migrate-foreachsequence-postfixexprbeginning-solver-based
branch
from
be35e75 to
95d3984
Compare
|
@swift-ci Please SourceKit stress test |
|
@swift-ci Please smoke test |
ahoppen
deleted the
pr/migrate-foreachsequence-postfixexprbeginning-solver-based
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate two more completion kinds (ForEachSequence and PostfixExprBeginning) to the solver-based implementation.