Skip to content

[stdlib] Added RISCV64 support #42055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

colemancda
Copy link
Contributor

Added support to cross-compile the StdLib for RISCV64.

Resolves SR-16005.

@colemancda
Copy link
Contributor Author

@buttaface this is an updated PR of #41858

@finagolfin
Copy link
Member

I would like to see Swift on RISC-V but I have not been able to buy any decent hardware, as I don't want to try running Swift on a microcontroller and the more powerful dev boards are always unavailable. I still don't think adding RISC-V to the LLVM targets in the linux buildbot preset is needed, as it should be there already, but I haven't checked.

@CodaFi, would you review?

@colemancda
Copy link
Contributor Author

colemancda commented Mar 28, 2022

@buttaface

I still don't think adding RISC-V to the LLVM targets in the linux buildbot preset is needed, as it should be there already, but I haven't checked.

I tried without changing the preset, its not there. You can also check the CI logs.

https://ci.swift.org/job/swift-PR-Linux/861/consoleFull

+ env /home/build-user/build/cmake-linux-x86_64/bin/cmake -G Ninja -DCMAKE_C_COMPILER:PATH=/usr/bin/clang -DCMAKE_CXX_COMPILER:PATH=/usr/bin/clang++ -DCMAKE_Swift_COMPILER:PATH= -DCMAKE_LIBTOOL:PATH= -DCMAKE_AR:PATH=/usr/bin/ar -DCMAKE_RANLIB:PATH=/usr/bin/ranlib -DLLVM_VERSION_MAJOR:STRING=13 -DLLVM_VERSION_MINOR:STRING=0 -DLLVM_VERSION_PATCH:STRING=0 -DCLANG_VERSION_MAJOR:STRING=13 -DCLANG_VERSION_MINOR:STRING=0 -DCLANG_VERSION_PATCH:STRING=0 -DCMAKE_MAKE_PROGRAM=/home/build-user/build/buildbot_linux/ninja-build/ninja -DLLVM_ENABLE_ASSERTIONS:BOOL=TRUE '-DLLVM_TARGETS_TO_BUILD=X86;ARM;AArch64;PowerPC;SystemZ;Mips' '-DCMAKE_C_FLAGS=  -Wno-unknown-warning-option -Werror=unguarded-availability-new -fno-stack-protector' '-DCMAKE_CXX_FLAGS=  -Wno-unknown-warning-option -Werror=unguarded-availability-new -fno-stack-protector' '-DCMAKE_C_FLAGS_RELWITHDEBINFO=-O2 -DNDEBUG' '-DCMAKE_CXX_FLAGS_RELWITHDEBINFO=-O2 -DNDEBUG' -DCMAKE_BUILD_TYPE:STRING=Release -DLLVM_TOOL_SWIFT_BUILD:BOOL=NO -DLLVM_TOOL_LLD_BUILD:BOOL=TRUE -DLLVM_INCLUDE_DOCS:BOOL=TRUE -DLLVM_ENABLE_LTO:STRING= -DCOMPILER_RT_INTERCEPT_LIBDISPATCH=ON -DLLVM_TOOL_COMPILER_RT_BUILD:BOOL=TRUE -DLLVM_BUILD_EXTERNAL_COMPILER_RT:BOOL=TRUE '-DLLVM_LIT_ARGS=-v --time-tests -j 36' -DCMAKE_INSTALL_PREFIX:PATH=/usr/ -DINTERNAL_INSTALL_PREFIX=local '-DLLVM_ENABLE_PROJECTS=clang;compiler-rt;clang-tools-extra;lld' /home/build-user/llvm-project/llvm
~/build/buildbot_linux/llvm-linux-x86_64 ~

@finagolfin
Copy link
Member

its not there. You can also check the CI logs.

I know we don't pass that flag, the question is whether it is built by default by LLVM when we don't specify the targets.

@colemancda
Copy link
Contributor Author

I got the main changes merged in #61815 and moved the build preset changes to #61891

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants