Skip to content

Do even less availability checking under -disable-availability-checking. #4214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2016

Conversation

jrose-apple
Copy link
Contributor

...and make sure we're in that mode for SIL inputs and for sil-opt and sil-extract, even when working with AST types and declarations rather than SIL types.

Without this, we get zillions of deprecation warnings coming out of the validation tests SIL/parse_stdlib_*.sil, which dump the standard library and then attempt to re-parse it. This has been causing the "long" tests to take, well, too long.


Before merging this pull request to apple/swift repository:

  • Test pull request on Swift continuous integration.

Triggering Swift CI

The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:

Smoke Testing

Platform Comment
All supported platforms @swift-ci Please smoke test
All supported platforms @swift-ci Please smoke test and merge
OS X platform @swift-ci Please smoke test OS X platform
Linux platform @swift-ci Please smoke test Linux platform

A smoke test on macOS does the following:

  1. Builds the compiler incrementally.
  2. Builds the standard library only for macOS. Simulator standard libraries and
    device standard libraries are not built.
  3. lldb is not built.
  4. The test and validation-test targets are run only for macOS. The optimized
    version of these tests are not run.

A smoke test on Linux does the following:

  1. Builds the compiler incrementally.
  2. Builds the standard library incrementally.
  3. lldb is built incrementally.
  4. The swift test and validation-test targets are run. The optimized version of these
    tests are not run.
  5. lldb is tested.

Validation Testing

Platform Comment
All supported platforms @swift-ci Please test
All supported platforms @swift-ci Please test and merge
OS X platform @swift-ci Please test OS X platform
OS X platform @swift-ci Please benchmark
Linux platform @swift-ci Please test Linux platform

Lint Testing

Language Comment
Python @swift-ci Please Python lint

Note: Only members of the Apple organization can trigger swift-ci.

@jrose-apple
Copy link
Contributor Author

@swift-ci Please smoke test

@jrose-apple
Copy link
Contributor Author

jrose-apple commented Aug 11, 2016

cc @shahmishal, @devincoughlin

@jrose-apple
Copy link
Contributor Author

@swift-ci Please smoke test Linux platform

2 similar comments
@jrose-apple
Copy link
Contributor Author

@swift-ci Please smoke test Linux platform

@shahmishal
Copy link
Member

@swift-ci Please smoke test Linux platform

@jrose-apple
Copy link
Contributor Author

One test is related to Michael's SceneKit changes, the other is me forgetting to update a test for this change.

...and make sure we're in that mode for SIL inputs and for sil-opt and
sil-extract, even when working with AST types and declarations rather
than SIL types.

Without this, we get zillions of deprecation warnings coming out of
the validation tests SIL/parse_stdlib_*.sil, which dump the standard
library and then attempt to re-parse it. This has been causing the
"long" tests to take, well, too long.
@jrose-apple jrose-apple force-pushed the SIL-is-always-available branch from 265522e to 5eb5843 Compare August 11, 2016 02:13
@jrose-apple
Copy link
Contributor Author

jrose-apple commented Aug 11, 2016

@jrose-apple
Copy link
Contributor Author

Let's try it again

@swift-ci Please smoke test

@jrose-apple
Copy link
Contributor Author

@swift-ci Please smoke test

@jrose-apple
Copy link
Contributor Author

Whew!

@jrose-apple jrose-apple merged commit 38e6b28 into swiftlang:master Aug 11, 2016
@jrose-apple jrose-apple deleted the SIL-is-always-available branch August 11, 2016 17:19
moiseev pushed a commit to moiseev/swift that referenced this pull request Aug 18, 2016
…ng. (swiftlang#4214)

...and make sure we're in that mode for SIL inputs and for sil-opt and
sil-extract, even when working with AST types and declarations rather
than SIL types.

Without this, we get zillions of deprecation warnings coming out of
the validation tests SIL/parse_stdlib_*.sil, which dump the standard
library and then attempt to re-parse it. This has been causing the
"long" tests to take, well, too long.
kateinoigakukun pushed a commit that referenced this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants