[swift-3.0-branch] Implementing SE-0137 #4361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux platform |
|
I think, #4214 is also needed. (to pass the |
|
@swift-ci test |
Using them is always a mistake; the user should choose the corresponding Collection protocol instead.
It's important to let people know that, in contrast with existing practice in other frameworks, we really are going to remove the deprecated API, and soon.
We know its API is inadequate (https://bugs.swift.org/browse/SR-1260?jql=text%20~%20%22StringInterpolationConvertible%22) and don't want to be constrained to supporting it in future versions.
…ertible Since the ExpressibleByStringInterpolation protocol is also deprecated now, it makes little sense to suggest using it instead of StringInterpolationConvertible. Instead, the message now recommends considering an init(_:String). See https://lists.swift.org/pipermail/swift-evolution/Week-of-Mon-20160808/026171.html for some more details.
…ng. (swiftlang#4214) ...and make sure we're in that mode for SIL inputs and for sil-opt and sil-extract, even when working with AST types and declarations rather than SIL types. Without this, we get zillions of deprecation warnings coming out of the validation tests SIL/parse_stdlib_*.sil, which dump the standard library and then attempt to re-parse it. This has been causing the "long" tests to take, well, too long.
|
Good catch, @rintaro! Thanks. |
|
Enough tests are passing to merge. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
rdar://problem/27894275
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
A smoke test on macOS does the following:
device standard libraries are not built.
version of these tests are not run.
A smoke test on Linux does the following:
tests are not run.
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.