[CodeCompletion] Teach TypeCheckASTNodeAtLocRequest to check initializers #42163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zers This simplifies the logic in `ide::typeCheckContextAt` and fixes an issue that prevent code completion from working inside variables that are initialized by calling a closure. Fixes rdar://90455154 [SR-16012] Fixes rdar://85600167 [SR-15495]
|
@swift-ci Please smoke test |
|
@swift-ci Please SourceKit stress test |
xedin
approved these changes
Apr 4, 2022
ahoppen
added a commit
to ahoppen/swift-source-compat-suite
that referenced
this pull request
Apr 5, 2022
SR-15495 and SR-16012 have been fixed by swiftlang/swift#42163
This was referenced Apr 20, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the logic in
ide::typeCheckContextAtand fixes an issue that prevent code completion from working inside variables that are initialized by calling a closure.I also considered getting rid of
LeaveClosureBodyUncheckedto resolve this issue, but that caused the closure types to not be applied to the AST and thus we couldn’t determine closure actor isolation. 😢Fixes rdar://90455154 [SR-16012]
Fixes rdar://85600167 [SR-15495]