[5.7][CodeCompletion] Teach TypeCheckASTNodeAtLocRequest to check initializers #42185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
changed the title
|
@swift-ci Please test |
xedin
approved these changes
Apr 5, 2022
|
@swift-ci please test macOS platform |
|
@swift-ci please test Windows platform |
|
@swift-ci please test Linux platform |
|
@swift-ci Please test macOS |
airspeedswift
approved these changes
Apr 12, 2022
…zers This simplifies the logic in `ide::typeCheckContextAt` and fixes an issue that prevent code completion from working inside variables that are initialized by calling a closure. Fixes rdar://90455154 [SR-16012] Fixes rdar://85600167 [SR-15495]
ahoppen
force-pushed
the
pr/fix-no-completion-in-closure-in-init
branch
from
cbbca38 to
0b3f2cc
Compare
|
@swift-ci Please test |
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #42163 to release/5.7.
This simplifies the logic in
ide::typeCheckContextAtand fixes an issue that prevent code completion from working inside variables that are initialized by calling a closure.Fixes rdar://90455154 [SR-16012]
Fixes rdar://85600167 [SR-15495]