Skip to content

[stdlib] prevent preventable buffer overflows when constructing Strings from C strings. #42221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 8, 2022
Merged

[stdlib] prevent preventable buffer overflows when constructing Strings from C strings. #42221

merged 15 commits into from
Apr 8, 2022

Conversation

glessard
Copy link
Contributor

@glessard glessard commented Apr 6, 2022 •
edited
Loading

Rebase of #42002, resolving rdar://90336023
Also includes #42232, which works around https://bugs.swift.org/browse/SR-16103.

glessard added 14 commits April 6, 2022 13:51
@glessard
[test] avoid using array conversion for String-from-C-string
5b0e7db
@glessard
[stdlib] harmonize parameter labels with StringProtocol
8fb64ae
@glessard
[stdlib] remove incorrect uses of pointer conversion
4c70f4e
@glessard
[stdlib] overload for arrays passed to String.init(cString:)
2868f62
@glessard
[stdlib] overload for arrays passed to String.init?(validatingUTF8:)
d1bc36e
@glessard
[stdlib] overload for arrays passed to String(decodeCString:as:)
d53436b
@glessard
[stdlib] String overloads for String-from-C-string inits
1b1bf8a
@glessard
[test] add tests of String-from-C-string Array overloads
a426c6c
@glessard
[test] add tests of String-from-C-string String overloads
02c0fa9
@glessard
[stdlib] overload String-from-C-string initializers in the case of in…
edef53a 
…out conversion
@glessard
[test] add tests of String-from-C-string inout conversion overloads
75741f5
@glessard
[test] check deprecation warnings for undesirable overloads
eb4f5cd
@glessard
[stdlib] improve the new deprecation messages
394f395
@glessard
[test] work around a linux testing issue
65cb705
@glessard glessard requested a review from a team as a code owner April 6, 2022 19:56
@glessard glessard requested a review from stephentyrone April 6, 2022 19:56
@glessard
Copy link
Contributor Author

glessard commented Apr 6, 2022

@swift-ci please smoke test

@glessard
Copy link
Contributor Author

glessard commented Apr 6, 2022

The linux test failure is unrelated to this change.

@glessard
Copy link
Contributor Author

glessard commented Apr 7, 2022

@swift-ci please test macOS platform

@glessard
Copy link
Contributor Author

glessard commented Apr 7, 2022

@swift-ci please test

@glessard
Copy link
Contributor Author

glessard commented Apr 8, 2022

Thanks @stephentyrone

@glessard glessard merged commit 174ca63 into swiftlang:release/5.7 Apr 8, 2022
@glessard glessard deleted the rdar90336023-5.7 branch April 8, 2022 19:24
@stephentyrone stephentyrone mentioned this pull request Apr 8, 2022
Merged
@glessard
Copy link
Contributor Author

glessard commented Apr 8, 2022

I suggest not including the deprecation warnings in the 5.7 branch. This would be the change.

@glessard glessard mentioned this pull request Apr 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentyrone stephentyrone stephentyrone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glessard @stephentyrone