Skip to content

[5.7][stdlib] Prevent preventable buffer overflows when constructing Strings from C strings. #42304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Apr 27, 2022
Merged

[5.7][stdlib] Prevent preventable buffer overflows when constructing Strings from C strings. #42304

merged 16 commits into from
Apr 27, 2022

Conversation

glessard
Copy link
Contributor

@glessard glessard commented Apr 11, 2022 •
edited
Loading

Cherry-pick of #42002, resolving rdar://90336023
Also includes #42232, which works around https://bugs.swift.org/browse/SR-16103.

An earlier version of this was merged in #42221, reverted in #42266.

@glessard glessard requested a review from a team as a code owner April 11, 2022 18:24
@glessard
Copy link
Contributor Author

@swift-ci please test

@glessard glessard changed the title [stdlib] prevent preventable buffer overflows when constructing Strings from C strings. [stdlib] Prevent preventable buffer overflows when constructing Strings from C strings. Apr 11, 2022
@glessard
Copy link
Contributor Author

@swift-ci please test source compatibility

@glessard
Copy link
Contributor Author

@swift-ci please test

glessard added 16 commits April 21, 2022 19:13
@glessard
[test] avoid using array conversion for String-from-C-string
490b4ec
@glessard
[stdlib] harmonize parameter labels with StringProtocol
cb04de1
@glessard
[stdlib] remove incorrect uses of pointer conversion
f641ca8
@glessard
[stdlib] overload for arrays passed to String.init(cString:)
2ede9a7
@glessard
[stdlib] overload for arrays passed to String.init?(validatingUTF8:)
d809640
@glessard
[stdlib] overload for arrays passed to String(decodeCString:as:)
63ba39f
@glessard
[stdlib] String overloads for String-from-C-string inits
1eee243
@glessard
[test] add tests of String-from-C-string Array overloads
7d2151f
@glessard
[test] add tests of String-from-C-string String overloads
1e5d690
@glessard
[stdlib] overload String-from-C-string initializers in the case of in…
0285602 
…out conversion
@glessard
[test] add tests of String-from-C-string inout conversion overloads
c594482
@glessard
[test] check deprecation warnings for undesirable overloads
59c1f42
@glessard
[stdlib] improve the new deprecation messages
d83d060
@glessard
[test] work around a linux testing issue
c3256a3
@glessard
[test] just don’t check for the crash message
044f436
@glessard
[test] check for availability before testing
ece2965 
- These tests verify updated behaviour of existing API, and should check for availability first.
@glessard
Copy link
Contributor Author

Force-pushed to fix a bad automatic merge.

@glessard
Copy link
Contributor Author

@swift-ci please test

@glessard glessard changed the title [stdlib] Prevent preventable buffer overflows when constructing Strings from C strings. [5.7][stdlib] Prevent preventable buffer overflows when constructing Strings from C strings. Apr 22, 2022
@glessard glessard merged commit 3e8d153 into swiftlang:release/5.7 Apr 27, 2022
@glessard glessard deleted the rdar90336023-5.7 branch April 27, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentyrone stephentyrone stephentyrone approved these changes

@airspeedswift airspeedswift Awaiting requested review from airspeedswift

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glessard @stephentyrone