Skip to content

Reapply [cxx-interop][libswift] Use std::string instead of BridgedStringRef #42297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 5, 2022
Merged

Reapply [cxx-interop][libswift] Use std::string instead of BridgedStringRef #42297

merged 3 commits into from
May 5, 2022

Conversation

egorzhdan
Copy link
Contributor

This reverts commit 2900dec

@egorzhdan egorzhdan force-pushed the egorzhdan/libswift-std-string branch 2 times, most recently from b29fa1a to 093d52d Compare April 11, 2022 15:32
@egorzhdan egorzhdan force-pushed the egorzhdan/libswift-std-string branch 4 times, most recently from 6fc827a to df9323a Compare April 26, 2022 17:33
@egorzhdan egorzhdan force-pushed the egorzhdan/libswift-std-string branch from df9323a to 9f4796b Compare April 26, 2022 23:18
@egorzhdan egorzhdan mentioned this pull request Apr 26, 2022
Merged
@egorzhdan egorzhdan force-pushed the egorzhdan/libswift-std-string branch from 9f4796b to f2c271f Compare April 27, 2022 23:46
@egorzhdan egorzhdan mentioned this pull request Apr 29, 2022
Merged
@egorzhdan egorzhdan force-pushed the egorzhdan/libswift-std-string branch 2 times, most recently from 6998153 to 801735f Compare April 29, 2022 18:22
@egorzhdan egorzhdan mentioned this pull request Apr 29, 2022
Merged
egorzhdan added 2 commits May 3, 2022 19:48
@egorzhdan
[cxx-interop][SwiftCompilerSources] Enable libstdc++ on platforms tha…
67a28c7 
…t use it

Since libstdc++ doesn't come with a Clang modulemap, Swift provides its own modulemap for libstdc++. This change makes the modulemap available while building SwiftCompilerSources.
@egorzhdan
[cxx-interop][SwiftCompilerSources] Use std::string instead of `Bri…
145ed33 
…dgedStringRef`

This reverts commit 2900dec
@egorzhdan egorzhdan force-pushed the egorzhdan/libswift-std-string branch from 801735f to 145ed33 Compare May 3, 2022 18:49
@egorzhdan egorzhdan marked this pull request as ready for review May 3, 2022 18:49
@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label May 4, 2022
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

eeckstein
eeckstein approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@egorzhdan egorzhdan merged commit 6332edb into main May 5, 2022
@egorzhdan egorzhdan deleted the egorzhdan/libswift-std-string branch May 5, 2022 15:42
@zoecarver
Copy link
Contributor

Awesome to see. Thank you Egor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eeckstein eeckstein eeckstein approved these changes

@zoecarver zoecarver Awaiting requested review from zoecarver zoecarver is a code owner

@ravikandhadai ravikandhadai Awaiting requested review from ravikandhadai

Assignees
No one assigned
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@egorzhdan @zoecarver @eeckstein