Skip to content

[cxx-interop] Fix SIL deserialization error for C++ methods #58537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2022
Merged

[cxx-interop] Fix SIL deserialization error for C++ methods #58537

merged 1 commit into from
May 3, 2022

Conversation

egorzhdan
Copy link
Contributor

This fixes Memory corruption or serialization format inconsistency error when compiling with cross module optimization enabled.

@egorzhdan
[cxx-interop] Fix SIL deserialization error for C++ methods
9ceebfd 
This fixes `Memory corruption or serialization format inconsistency` error when compiling with cross module optimization enabled.
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan
Copy link
Contributor Author

This is a requirement for #42297.
There won't be a test in this change, since we still get a crash later during deserialization. I will submit another patch to fix that.

@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Apr 29, 2022
@egorzhdan egorzhdan requested a review from zoecarver April 29, 2022 18:09
@egorzhdan egorzhdan merged commit 51edb8f into main May 3, 2022
@egorzhdan egorzhdan deleted the egorzhdan/cxx-method-deserialization branch May 3, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoecarver zoecarver zoecarver approved these changes

Assignees
No one assigned
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egorzhdan @zoecarver