Add missing parameter in UnsafeMutableRawPointer
#42318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here, as in UnsafeMutableRawPointer.storeBytes(of:toByteOffset:as:) "as" is an argument label and "type" is the parameter. Because the function body doesn't use this -- it's just for type information -- changing its name from "as" to "type" doesn't have any impact there.
|
@swift-ci Please smoke test. |
glessard
reviewed
Apr 12, 2022
glessard
approved these changes
Apr 12, 2022
|
@swift-ci Please smoke test Linux. |
|
@swift-ci please smoke test linux |
1 similar comment
|
@swift-ci please smoke test linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here, as in
UnsafeMutableRawPointer.storeBytes(of:toByteOffset:as:)"as" is an argument label and "type" is the parameter. Because the function body doesn't use this — it's just for type information — changing its name from "as" to "type" doesn't have any impact there.I'm making this PR separate from the PR to fix the docs, which is already merged.
This change is also on a separate "do-not-merge" PR for an upcoming SE pitch in 067a14962bc482256b0c45ceed2edc136a75d407. If we merge that, we can discard this focused PR.