-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[SE-0349] Implementation for unaligned loads from raw memory #41033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a9dffcb
to
46d88d6
Compare
8f4883c
to
04206bc
Compare
@swift-ci please smoke test |
d39ffd1
to
12b683c
Compare
- preserve previous version for ABI and source stability. - add new version without alignment restriction. - add explicit POD type enforcement in new version.
- preserve previous version for ABI and source stability. - add new version without alignment restriction. - add explicit POD type enforcement in new version.
(rebased to incorporate #42318) |
@swift-ci please test |
@swift-ci please test macOS platform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good. Thanks!
Q: Do we need to add new tests for unaligned storeBytes?
I'll add the valid unaligned one; I started writing that, but it turned into a test for an invalid store… |
@swift-ci please test and merge |
@swift-ci please test and merge |
Implementation for SE-0349, adding unaligned load API to
UnsafeRawPointer
and related types.The proposal acceptance is here.
Resolves SR-10273 (rdar://63919502), and rdar://91705753