-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[5.7][SE-0349] Implementation for unaligned loads from raw memory #42401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@swift-ci please test |
48eacaa
to
ef28b80
Compare
Force-pushed to resolve changelog conflict! |
@swift-ci please test |
Here, as in UnsafeMutableRawPointer.storeBytes(of:toByteOffset:as:) "as" is an argument label and "type" is the parameter. Because the function body doesn't use this -- it's just for type information -- changing its name from "as" to "type" doesn't have any impact there.
- preserve previous version for ABI and source stability. - add new version without alignment restriction. - add explicit POD type enforcement in new version.
- preserve previous version for ABI and source stability. - add new version without alignment restriction. - add explicit POD type enforcement in new version.
ef28b80
to
7bd26e4
Compare
@swift-ci please test |
stephentyrone
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for SE-0349, cherry-picked from #41033