Use AbstractStorageDecl::isSettableInSwift to prohibit direct writes to optional requirements
#42455
Conversation
AnthonyLatsis
force-pushed
the
objc-optional-keypath-fixes
branch
from
a32a8d4 to
ecf865d
Compare
|
@swift-ci Please test |
|
Hi Anthony! I'm the one who's been making the minimized cases Joe's been sharing—happy to report this seems to fix the actual crashes in the project I've been minimizing cases from. |
|
Glad to hear. Sorry for the trouble! |
AnthonyLatsis
force-pushed
the
objc-optional-keypath-fixes
branch
from
ecf865d to
a5077e4
Compare
|
Switched to |
| @@ -0,0 +1,12 @@ | |||
| // RUN: %target-swift-emit-silgen -import-objc-header %swift_src_root/test/Inputs/ObjCOptionalRequirements.h %s | %FileCheck %s | |||
|
|
|||
| // REQUIRES: objc_interop | |||
There was a problem hiding this comment.
What are the criteria for REQUIRES: objc_interop? Could tests like these simply -enable-objc-interop?
There was a problem hiding this comment.
Apparently linux is not happy with -enable-objc-interop when importing a header, even though the test passed when an Objective-C module was being imported instead.
There was a problem hiding this comment.
REQUIRES: objc_interop is enabled when the target runtime is built with ObjC interop, which is practically only on Apple platforms. -enable-objc-interop's behavior is only maintained on those platforms, so I don't think it makes sense to try to test it when running tests for target platforms that don't have ObjC interop.
|
@swift-ci please test |
AnthonyLatsis
force-pushed
the
objc-optional-keypath-fixes
branch
from
a5077e4 to
f27b316
Compare
…s to `optional` requirements Stop pretending that an optional requirement is immutable via the `StorageImplInfo` request. This approach has lead astray the conformance checker and may have had a negative impact on other code paths, and it doesn't work for imported declarations because they bypass the request. Instead, use a forwarding `AbstractStorageDecl::isSettableInSwift` method that special-cases optional requirements.
AnthonyLatsis
force-pushed
the
objc-optional-keypath-fixes
branch
from
f27b316 to
934964d
Compare
|
@swift-ci please test |
Stop pretending that an optional requirement is immutable via the
StorageImplInforequest. This approach has lead astray the conformance checker and may have had a negative impact on other code paths that expectisSettableorsupportsMutationto mean "has a setter", and it doesn't work for imported declarations because they bypass the request. Instead, use a forwardingAbstractStorageDecl::isSettableInSwiftmethod that special-cases optional requirements.