🍒 [5.7] Use AbstractStorageDecl::isSettableInSwift to prohibit direct writes to optional requirements
#42490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to `optional` requirements Stop pretending that an optional requirement is immutable via the `StorageImplInfo` request. This approach has lead astray the conformance checker and might have had a negative impact on other code paths that expect `isSettable` or `supportsMutation` to mean "has a setter". Also, this does not work for imported foreign declarations, since they bypass the request. Instead, use a forwarding `AbstractStorageDecl::isSettableInSwift` method that special-cases optional requirements. This is a follow-up fix for a regression caused by swiftlang#42384.
|
@swift-ci Please test |
hborla
approved these changes
Apr 20, 2022
aschwaighofer
pushed a commit
to aschwaighofer/swift
that referenced
this pull request
May 10, 2022
…al-keypath-fix 🍒 [5.7-04182022] Use `AbstractStorageDecl::isSettableInSwift` to prohibit direct writes to `optional` requirements
aschwaighofer
added a commit
that referenced
this pull request
May 10, 2022
…al-keypath-fix Merge pull request #42490 from AnthonyLatsis/5.7-objc-optional-keypath-fix
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StorageImplInforequest. This approach has lead astray the conformance checker and might have had a negative impact on other code paths that expectisSettableorsupportsMutationto mean "has a setter". Also, this does not work for imported foreign declarations, since they bypass the request. Instead, use a forwardingAbstractStorageDecl::isSettableInSwiftmethod that special-cases optional requirements. This is a follow-up fix for a regression caused by 🍒 [5.7] CS:optionalstorage key path components are read-only #42384.optionalstorage components.optionalproperty requirement cannot be witnessed by a get-only property.AbstractStorageDecl::isSettableInSwiftto prohibit direct writes tooptionalrequirements #42455