Spelling utils

[jsoref]

This fixes some misspellings in Swift utils, it is split per #42421 (comment)

[tshortli]

@swift-ci please test

[tshortli]

ImportError: cannot import name 'TRIVIAS' from 'gyb_syntax_support.Trivia' (/Users/ec2-user/jenkins/workspace/swift-PR-macos/branch-main/swift/utils/gyb_syntax_support/Trivia.py)

[tshortli]

Thanks for this PR! The build failure appears to be related to the trivias -> trivia change. I skimmed over all of the changes and that was the only one I wasn't sure whether we should make. I think the authors of the code using "trivias" likely wanted to disambiguate collections from variables representing singular trivia for clarity in the code, so even though it's not a valid pluralization it may still be desirable. I don't work on the parser, though, so I'll add some reviewers who may be able to weigh in on that.

[jsoref]

Right, I should have tagged that here. I think I called it out in the parent PR.

It's easy to drop the change, or to pull in the piece that was clipped by the directory split.

I won't be able to do either until tonight, but hopefully I'll have direction from a reviewer by then.

[tshortli]

Right, I should have tagged that here. I think I called it out in the parent PR.

It's easy to drop the change, or to pull in the piece that was clipped by the directory split.

I won't be able to do either until tonight, but hopefully I'll have direction from a reviewer by then.

I think the most straightforward thing to do here is drop the trivia change from this PR. Everything else looks good to me.

[rintaro]

TRIVIAS change requires a synchronous change in swift-syntax repo. I would prefer to drop the change from this PR.

As for the TRIVIAS, I don't have a strong opinion. Though, as a non-native English speaker, it doesn't look strange, and the presence of S is helpful to indicate that it is a collection. But I don't know how native speakers feel. Paging @ahoppen

[tshortli]

@swift-ci please test

[CodaFi]

@swift-ci python lint

[ahoppen]

Thanks a lot for this PR. There are way more spelling errors than I expected. Fixing them is great. 🙏

I reviewed the changes in gyb_syntax_support, incrparse and parser-lib and added a few inline comments.

[tshortli]

@swift-ci please test

[tshortli]

@jsoref looks good, just needs a conflict resolution before this can land

[ahoppen]

@swift-ci Please smoke test

[ahoppen]

Changes in incrparse look good to me – I didn’t review the other changes.

[tshortli]

@swift-ci please smoke test