Spelling #42421

jsoref · 2022-04-18T02:29:11Z

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at jsoref@5656126#commitcomment-71491159

The action reports that the changes in this PR would make it happy: jsoref@10e98f4

Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.

I don't expect this to be merged as-is. For large changes (like this one), I tend to split based on some criteria, often that's by directory. I try to avoid squashing until the very end as it makes it very hard to rebase.

I will try to annotate this PR, but it'll take a while.

jsoref

This is a checkpoint (~300 files). Most of the corrections were suggested by Google Sheets, and most of the time it was correct. There are a handful of things where a correction I applied was clearly wrong, and I'll fix them up once I get to the end of my review.

All fault is mine. I really am human.

jsoref · 2022-04-18T02:30:21Z

CHANGELOG.md

-  func hadWithdrawlOn(_ day: Date, from acct: BankAccount) async -> Bool {
+  func hadWithdrawalOn(_ day: Date, from acct: BankAccount) async -> Bool {


Some projects don't like making changes to the changelog after publishing. Let me know if that applies here. I can easily drop changes to any specific file(s)

jsoref · 2022-04-18T02:33:05Z

CHANGELOG.md

-  These functions change the control flow of a program in ways that that Swift
+  These functions change the control flow of a program in ways that Swift


I've been experimenting with heuristics for doubled words.

CHANGELOG.md

jsoref · 2022-04-18T02:34:22Z

CHANGELOG.md

-[SE-0110]: <https://github.com/apple/swift-evolution/blob/main/proposals/0110-distingish-single-tuple-arg.md>
+[SE-0110]: <https://github.com/apple/swift-evolution/blob/main/proposals/0110-distinguish-single-tuple-arg.md>


This would require changing the other repository

jsoref · 2022-04-18T02:37:37Z

CODE_OWNERS.TXT

-N: Argyrios Kyrzidis
+N: Argyrios Kyrtzidis
 E: [email protected]


The email address appears correct and this is the name.

jsoref · 2022-04-18T03:21:19Z

lib/AST/ASTContext.cpp

-  auto clas = t->getClassOrBoundGenericClass();
-  if (!clas)
+  auto clazz = t->getClassOrBoundGenericClass();
+  if (!clazz)


Happy to drop, but clazz (and klass) are also used...

lib/AST/DeclContext.cpp

lib/DependencyScan/ScanDependencies.cpp

jsoref · 2022-04-18T03:44:58Z

lib/DriverTool/swift_api_digester_main.cpp

-  // locats before less favored ones.
+  // locals before less favored ones.


? unless it's short for locations?

jsoref · 2022-04-18T03:47:14Z

lib/IDE/CompletionLookup.cpp

 /// This doesn't match the condition because the base name of the function in
-/// Swift is 'peform':
+/// Swift is 'perform':
 ///
 ///   func perform(options opts: [AnyHashable:Any] = [:])


CodaFi · 2022-04-18T04:24:15Z

Hi @jsoref, thanks for your contribution here.

A diff of this size covering this much code and with this many commits is extremely difficult for even a group of reviewers to make their way through. Please clean up the history by squashing these patches together into topic-level commits - perhaps organized by component - and consider splitting this into separate patches.

EDIT: I see you’ve already realized this, and I appreciate the process being laid out here. Would you mind setting this PR in draft mode until you’re ready for review? I’d also caution against changes in tests and their inputs as well as changes to variable names in compiler code.

CodaFi · 2022-04-18T04:51:40Z

The broad strokes of this look pretty good. I think the changes to user-facing documentation, compiler documentation, and the CHANGELOG need to generally be split from everything else. The code changes need to be chunked by component - but they should generally not be controversial.

jsoref · 2022-04-18T14:33:56Z

Thanks @CodaFi.

Do you want three distinct PRs for:

user-facing documentation,
compiler documentation,
the CHANGELOG

vs. just one PR for the set?

For large PRs, I tend to use one PR to hang the story (=this) and then smaller ones that reference back to it.

My guess is that for components, roughly each directory in https://github.com/apple/swift/tree/main/lib is a component, and I'd make distinct ones for each.

Is https://github.com/apple/swift/tree/main/stdlib a single component?
And would you want https://github.com/apple/swift/tree/main/tools to be treated as a single thing?

breakdown of changes by second level directories

for a in */*/; do changes=$(git diff main..spelling --stat -- $a |tail -1); [ -n "$changes" ] && echo "$changes $a"; done|sort -nr
 160 files changed, 394 insertions(+), 394 deletions(-) include/swift/
 98 files changed, 230 insertions(+), 230 deletions(-) test/SILOptimizer/
 85 files changed, 230 insertions(+), 230 deletions(-) lib/SILOptimizer/
 51 files changed, 115 insertions(+), 115 deletions(-) stdlib/public/
 46 files changed, 205 insertions(+), 205 deletions(-) lib/Sema/
 33 files changed, 123 insertions(+), 123 deletions(-) test/refactoring/
 32 files changed, 90 insertions(+), 90 deletions(-) test/IDE/
 32 files changed, 75 insertions(+), 75 deletions(-) lib/AST/
 30 files changed, 79 insertions(+), 79 deletions(-) lib/IRGen/
 30 files changed, 67 insertions(+), 67 deletions(-) test/Interop/
 27 files changed, 131 insertions(+), 131 deletions(-) lib/IDE/
 25 files changed, 101 insertions(+), 101 deletions(-) test/SILGen/
 23 files changed, 78 insertions(+), 78 deletions(-) test/SourceKit/
 20 files changed, 62 insertions(+), 62 deletions(-) lib/SIL/
 16 files changed, 29 insertions(+), 29 deletions(-) lib/SILGen/
 16 files changed, 23 insertions(+), 23 deletions(-) test/stdlib/
 14 files changed, 35 insertions(+), 35 deletions(-) tools/SourceKit/
 13 files changed, 26 insertions(+), 26 deletions(-) test/decl/
 12 files changed, 16 insertions(+), 16 deletions(-) utils/build_swift/
 12 files changed, 16 insertions(+), 16 deletions(-) test/Constraints/
 11 files changed, 16 insertions(+), 16 deletions(-) test/AutoDiff/
 10 files changed, 19 insertions(+), 19 deletions(-) test/Parse/
 10 files changed, 11 insertions(+), 11 deletions(-) stdlib/private/
 9 files changed, 28 insertions(+), 28 deletions(-) lib/Parse/
 9 files changed, 12 insertions(+), 12 deletions(-) benchmark/single-source/
 8 files changed, 33 insertions(+), 33 deletions(-) validation-test/stdlib/
 8 files changed, 23 insertions(+), 23 deletions(-) lib/Frontend/
 8 files changed, 12 insertions(+), 12 deletions(-) SwiftCompilerSources/Sources/
 8 files changed, 11 insertions(+), 11 deletions(-) utils/gyb_syntax_support/
 8 files changed, 11 insertions(+), 11 deletions(-) test/Sema/
 7 files changed, 8 insertions(+), 8 deletions(-) test/ClangImporter/
 7 files changed, 32 insertions(+), 32 deletions(-) test/SIL/
 7 files changed, 17 insertions(+), 17 deletions(-) lib/Serialization/
 7 files changed, 10 insertions(+), 10 deletions(-) lib/ClangImporter/
 6 files changed, 23 insertions(+), 23 deletions(-) benchmark/scripts/
 6 files changed, 11 insertions(+), 11 deletions(-) test/Concurrency/
 5 files changed, 6 insertions(+), 6 deletions(-) docs/proposals/
 5 files changed, 19 insertions(+), 19 deletions(-) test/attr/
 5 files changed, 19 insertions(+), 19 deletions(-) test/api-digester/
 4 files changed, 7 insertions(+), 7 deletions(-) unittests/runtime/
 4 files changed, 7 insertions(+), 7 deletions(-) test/Interpreter/
 4 files changed, 5 insertions(+), 5 deletions(-) test/Frontend/
 4 files changed, 5 insertions(+), 5 deletions(-) stdlib/include/
 4 files changed, 4 insertions(+), 4 deletions(-) test/ModuleInterface/
 4 files changed, 13 insertions(+), 13 deletions(-) lib/Driver/
 3 files changed, 6 insertions(+), 6 deletions(-) lib/Migrator/
 3 files changed, 6 insertions(+), 6 deletions(-) lib/FrontendTool/
 3 files changed, 5 insertions(+), 5 deletions(-) utils/swift_build_support/
 3 files changed, 5 insertions(+), 5 deletions(-) test/Serialization/
 3 files changed, 5 insertions(+), 5 deletions(-) test/Distributed/
 3 files changed, 5 insertions(+), 5 deletions(-) docs/CppInteroperability/
 3 files changed, 4 insertions(+), 4 deletions(-) test/expr/
 3 files changed, 4 insertions(+), 4 deletions(-) lib/SymbolGraphGen/
 3 files changed, 3 insertions(+), 3 deletions(-) test/Syntax/
 3 files changed, 3 insertions(+), 3 deletions(-) test/Index/
 3 files changed, 20 insertions(+), 20 deletions(-) lib/DependencyScan/
 3 files changed, 16 insertions(+), 16 deletions(-) lib/Basic/
 2 files changed, 7 insertions(+), 7 deletions(-) lib/Index/
 2 files changed, 5 insertions(+), 5 deletions(-) unittests/SourceKit/
 2 files changed, 3 insertions(+), 3 deletions(-) utils/incrparse/
 2 files changed, 3 insertions(+), 3 deletions(-) test/multifile/
 2 files changed, 3 insertions(+), 3 deletions(-) test/SymbolGraph/
 2 files changed, 3 insertions(+), 3 deletions(-) test/Inputs/
 2 files changed, 3 insertions(+), 3 deletions(-) cmake/modules/
 2 files changed, 2 insertions(+), 2 deletions(-) unittests/Driver/
 2 files changed, 2 insertions(+), 2 deletions(-) tools/swift-inspect/
 2 files changed, 2 insertions(+), 2 deletions(-) test/type/
 2 files changed, 2 insertions(+), 2 deletions(-) test/ScanDependencies/
 2 files changed, 2 insertions(+), 2 deletions(-) test/SPI/
 2 files changed, 2 insertions(+), 2 deletions(-) test/Prototypes/
 2 files changed, 2 insertions(+), 2 deletions(-) stdlib/toolchain/
 2 files changed, 2 insertions(+), 2 deletions(-) docs/archive/
 1 file changed, 8 insertions(+), 8 deletions(-) docs/RequirementMachine/
 1 file changed, 6 insertions(+), 6 deletions(-) utils/parser-lib/
 1 file changed, 4 insertions(+), 4 deletions(-) tools/swift-syntax-test/
 1 file changed, 4 insertions(+), 4 deletions(-) tools/swift-ide-test/
 1 file changed, 4 insertions(+), 4 deletions(-) test/Misc/
 1 file changed, 4 insertions(+), 4 deletions(-) lib/APIDigester/
 1 file changed, 3 insertions(+), 3 deletions(-) unittests/Sema/
 1 file changed, 3 insertions(+), 3 deletions(-) test/diagnostics/
 1 file changed, 3 insertions(+), 3 deletions(-) test/Profiler/
 1 file changed, 2 insertions(+), 2 deletions(-) utils/api_checker/
 1 file changed, 2 insertions(+), 2 deletions(-) unittests/FrontendTool/
 1 file changed, 2 insertions(+), 2 deletions(-) unittests/ClangImporter/
 1 file changed, 2 insertions(+), 2 deletions(-) tools/swift-serialize-diagnostics/
 1 file changed, 2 insertions(+), 2 deletions(-) test/swift-indent/
 1 file changed, 2 insertions(+), 2 deletions(-) test/Migrator/
 1 file changed, 2 insertions(+), 2 deletions(-) stdlib/cmake/
 1 file changed, 2 insertions(+), 2 deletions(-) lib/SyntaxParse/
 1 file changed, 2 insertions(+), 2 deletions(-) lib/PrintAsClang/
 1 file changed, 2 insertions(+), 2 deletions(-) docs/ReferenceGuides/
 1 file changed, 2 insertions(+), 2 deletions(-) docs/ABI/
 1 file changed, 2 insertions(+), 2 deletions(-) benchmark/utils/
 1 file changed, 19 insertions(+), 19 deletions(-) test/PrintAsObjC/
 1 file changed, 10 insertions(+), 10 deletions(-) lib/DriverTool/
 1 file changed, 1 insertion(+), 1 deletion(-) validation-test/Runtime/
 1 file changed, 1 insertion(+), 1 deletion(-) validation-test/Evolution/
 1 file changed, 1 insertion(+), 1 deletion(-) validation-test/BuildSystem/
 1 file changed, 1 insertion(+), 1 deletion(-) utils/update_checkout/
 1 file changed, 1 insertion(+), 1 deletion(-) utils/bug_reducer/
 1 file changed, 1 insertion(+), 1 deletion(-) unittests/DependencyScan/
 1 file changed, 1 insertion(+), 1 deletion(-) unittests/Basic/
 1 file changed, 1 insertion(+), 1 deletion(-) unittests/AST/
 1 file changed, 1 insertion(+), 1 deletion(-) test/TBD/
 1 file changed, 1 insertion(+), 1 deletion(-) test/Sanitizers/
 1 file changed, 1 insertion(+), 1 deletion(-) test/Runtime/
 1 file changed, 1 insertion(+), 1 deletion(-) test/NameLookup/
 1 file changed, 1 insertion(+), 1 deletion(-) test/Driver/
 1 file changed, 1 insertion(+), 1 deletion(-) test/CrossImport/
 1 file changed, 1 insertion(+), 1 deletion(-) test/Compatibility/
 1 file changed, 1 insertion(+), 1 deletion(-) lib/TBDGen/
 1 file changed, 1 insertion(+), 1 deletion(-) lib/Syntax/
 1 file changed, 1 insertion(+), 1 deletion(-) lib/Option/
 1 file changed, 1 insertion(+), 1 deletion(-) lib/Localization/
 1 file changed, 1 insertion(+), 1 deletion(-) lib/Demangling/
 1 file changed, 1 insertion(+), 1 deletion(-) docs/refactoring/

Fwiw, it looks like I could split stdlib/public/runtime/, stdlib/public/core/, stdlib/public/Concurrency/, and treat the rest together:

stdlib/*/*

for a in stdlib/*/*/; do changes=$(git diff main..spelling --stat -- $a |tail -1); [ -n "$changes" ] && echo "$changes $a"; done|sort -nr
 14 files changed, 42 insertions(+), 42 deletions(-) stdlib/public/runtime/
 14 files changed, 20 insertions(+), 20 deletions(-) stdlib/public/core/
 12 files changed, 40 insertions(+), 40 deletions(-) stdlib/public/Concurrency/
 6 files changed, 7 insertions(+), 7 deletions(-) stdlib/private/OSLog/
 4 files changed, 5 insertions(+), 5 deletions(-) stdlib/public/SwiftShims/
 4 files changed, 5 insertions(+), 5 deletions(-) stdlib/include/llvm/
 3 files changed, 3 insertions(+), 3 deletions(-) stdlib/private/StdlibUnicodeUnittest/
 2 files changed, 3 insertions(+), 3 deletions(-) stdlib/public/Distributed/
 1 file changed, 2 insertions(+), 2 deletions(-) stdlib/cmake/modules/
 1 file changed, 1 insertion(+), 1 deletion(-) stdlib/toolchain/Compatibility51/
 1 file changed, 1 insertion(+), 1 deletion(-) stdlib/toolchain/Compatibility50/
 1 file changed, 1 insertion(+), 1 deletion(-) stdlib/public/SwiftRemoteMirror/
 1 file changed, 1 insertion(+), 1 deletion(-) stdlib/public/SwiftOnoneSupport/
 1 file changed, 1 insertion(+), 1 deletion(-) stdlib/public/Reflection/
 1 file changed, 1 insertion(+), 1 deletion(-) stdlib/public/Platform/
 1 file changed, 1 insertion(+), 1 deletion(-) stdlib/public/BackDeployConcurrency/
 1 file changed, 1 insertion(+), 1 deletion(-) stdlib/private/StdlibCollectionUnittest/

Would you want to have all the PRs open at once, or to only approach a limited number of PRs at a time (1-5?). I tend not to put too many up at once as I don't want to overwhelm CI or reviewers. But I try to be flexible (and I'm not in any hurry, in fact I'm on 🌴 vacation).

(Still working on the next round of checks, but I figured I'd respond first.)

CodaFi · 2022-04-18T15:54:41Z

Do you want three distinct PRs for:

Yes. Each one of these has a different set of reviewers and intended audiences.

My guess is that for components, roughly each directory... is a component

Bingo

Would you want to have all the PRs open at once, or to only approach a limited number of PRs at a time

I don't mind multiples of these being open as long as we're allowed a little more leeway with review times for the patches when many are in flight.

and I'm not in any hurry, in fact I'm on 🌴 vacation

🏖️

jsoref

Checkpoint. I'll probably have two more rounds before I do an update to clear up the errors I've identified.

lib/IRGen/GenReflection.cpp

jsoref · 2022-04-18T14:40:28Z

lib/Migrator/README.md

-     for [SE-0110: Distinguish between single-tuple and multiple-argument function types](https://github.com/apple/swift-evolution/blob/master/proposals/0110-distingish-single-tuple-arg.md).
+     for [SE-0110: Distinguish between single-tuple and multiple-argument function types](https://github.com/apple/swift-evolution/blob/master/proposals/0110-distinguish-single-tuple-arg.md).


Another external reference. It'd be helpful to know if such changes can be made or if I should drop them. As there don't seem to be many of them, I think I'll flag them all -- so I can address them either way.

It might make sense for me to split these changes out into a single PR so that there's a PR to rename on that side and a PR to update the references on this side that could be merged as soon as that PR is merged.

lib/SIL/Utils/DynamicCasts.cpp

jsoref · 2022-04-18T15:09:05Z

lib/SILGen/SILGenPattern.cpp

-  // Why do we need to do this here (I just cargo culted this).
+  // Why do we need to do this here (I just cargo-culted this).


This matches another instance elsewhere.

jsoref · 2022-04-18T15:13:02Z

lib/SILGen/SILGenType.cpp

-      auto *reqrRerivativeId = requirementRef.getDerivativeFunctionIdentifier();
+      auto *reqrDerivativeId = requirementRef.getDerivativeFunctionIdentifier();


Reasonably confident, but not entirely. It's possible that the R is for Ref...

stdlib/public/SwiftOnoneSupport/CMakeLists.txt

jsoref · 2022-04-18T16:48:12Z

stdlib/public/core/UnicodeScalarProperties.swift

@@ -1184,10 +1184,10 @@ extension Unicode.Scalar.Properties {
  }

  // Used to potentially return a name who can either be represented in a large


I think who probably should be that, but it's outside of scope.

jsoref · 2022-04-18T16:49:22Z

stdlib/public/runtime/MetadataLookup.cpp

-  // This is a type that convers entire parameter list.
+  // This is a type that covers entire parameter list.
  auto parameterList = parameterContainer->getFirstChild();
  assert(parameterList->getKind() == Node::Kind::Type);


I actually spent a bit of time trying to think through this one (vs converts). I think I'm right, but I'm not at all confident.

jsoref · 2022-04-18T16:50:34Z

stdlib/toolchain/Compatibility50/CompatibilityOverride.h

-//===--- CompatibiltyOverride.h - Back-deploying compatibility fixes --*- C++ -*-===//
+//===--- CompatibilityOverride.h - Back-deploying compatibility fixes --*- C++ -*-===//


Wondering which side I'm comping the character -- still assuming it's the --*- side...

jsoref · 2022-04-18T16:51:19Z

test/AutoDiff/IRGen/runtime.swift

 // CHECK-LABEL: define{{.*}}@test_context_builtins()
 // CHECK: entry:
 // CHECK:   [[CTX:%.*]] = call swiftcc %swift.refcounted* @swift_autoDiffCreateLinearMapContext({{i[0-9]+}} {{.*}})
-// CEHCK:   call swiftcc i8* @swift_autoDiffProjectTopLevelSubcontext(%swift.refcounted* [[CTX]])
+// CHECK:   call swiftcc i8* @swift_autoDiffProjectTopLevelSubcontext(%swift.refcounted* [[CTX]])
 // CHECK:   [[BUF:%.*]] = call swiftcc i8* @swift_autoDiffAllocateSubcontext(%swift.refcounted* [[CTX]], {{i[0-9]+}} {{.*}})


There were a bunch of things w/ slight variations of what I'd expect. It's possible they're intentional, but I've made the default assumption that they're accidental.

jsoref

Checkpointing

jsoref · 2022-04-18T17:29:19Z

test/ClangImporter/experimental_diagnostics_cmacros.swift

 // CHECK-NEXT:      macros.h:{{[0-9]+}}:9: note: macro 'INVALID_ARITHMETIC_1' not imported: structure not supported
-// CHECK-NEXT:      #define INVALID_ARITHMETIC_1 5 + INVALID_INTERGER_LITERAL_1
+// CHECK-NEXT:      #define INVALID_ARITHMETIC_1 5 + INVALID_INTEGER_LITERAL_1
 // CHECK-NEXT: {{^}}        ^


These changes scare me.

jsoref · 2022-04-18T17:30:12Z

test/ClangImporter/objc_direct.swift

-var otherthing = Foo() as AnyObject
+var otherThing = Foo() as AnyObject

 // We expect no error.
-let _ = otherthing.directProtocolMethod()
+let _ = otherThing.directProtocolMethod()


I can drop this change if there's a preference, but Swift seems to use camelCase and TitleCase for things, so there didn't seem to be any harm.

jsoref · 2022-04-18T17:31:17Z

test/Constraints/generics.swift

-// rdar://79757320 - failured to produce a diagnostic when unresolved dependent member is used in function result position
+// rdar://79757320 - failed to produce a diagnostic when unresolved dependent member is used in function result position


I think this is right, but it's a notable change

test/Driver/loaded_module_trace_directness_2.swift

jsoref · 2022-04-18T17:34:43Z

test/Constraints/members.swift

-  _ = pair["strting"] // expected-error {{cannot access element using subscript for tuple type '(Int, Int)'; use '.' notation instead}} {{none}}
+  _ = pair["string"] // expected-error {{cannot access element using subscript for tuple type '(Int, Int)'; use '.' notation instead}} {{none}}


I'm pretty sure it's complaining about the fact that it's a string and not that the value is strting.

jsoref · 2022-04-18T20:43:04Z

test/SILGen/hop_to_executor_async_prop.swift

-final private actor Coordinactor {
+final private actor Coordinator {
    var someValue: Int?


it's possible that this was intentionally -actor

test/SILGen/witnesses.swift

jsoref · 2022-04-18T21:00:46Z

test/SILOptimizer/copy_propagation.sil

-// -Onone reuses the existint lifetime-ending destroy.
+// -Onone reuses the existing lifetime-ending destroy.


Alternative is existent

test/SILOptimizer/global_hoisting_crash.swift

jsoref · 2022-04-18T21:17:18Z

test/SILOptimizer/optimize_keypath.swift

-// allow exactly one unoptimzedkey path instruction, in this function
+// allow exactly one unoptimized key path instruction, in this function


This split a word, I believe this is right choice.

jsoref

ok, done reviewing. I'll try to fix up the things I've identified shortly.

jsoref · 2022-04-18T22:24:15Z

test/attr/attr_native_dynamic.swift

-struct Strukt {
-  // CHECK: (struct_decl {{.*}} "Strukt"
+struct Struct {
+  // CHECK: (struct_decl {{.*}} "Struct"


Moderately worried

test/diagnostics/Localization/no_localization_files_and_wrong_path.swift

jsoref · 2022-04-18T22:27:37Z

validation-test/stdlib/ExistentialCollection.swift.gyb

-  let s0 = "Hello, Woyld"
+  let s0 = "Hello, World"


Some projects use cute styles, overall, Swift doesn't seem to be very heavy in this category, but I'm happy to drop this.

jsoref · 2022-04-18T22:34:34Z

utils/parser-lib/profile-input.swift

-        if let queuedAlertInfo = tabManager.selectedTab?.dequeueJavascriptAlertPrompt() {
+        if let queuedAlertInfo = tabManager.selectedTab?.dequeueJavaScriptAlertPrompt() {


There's no matching item, so this is presumably wrong.

But the only reference to this anywhere appears to be here. So ??

utils/gyb_syntax_support/Trivia.py

unittests/Basic/PrefixMapTest.cpp

jsoref · 2022-04-18T22:42:07Z

unittests/DependencyScan/Features.cpp

-  hasOption = optionSet.find("-emit-modul") != optionSet.end();
+  hasOption = optionSet.find("-emit-module") != optionSet.end();


Not sure what this is doing. (Presumably the change is wrong, but...)

jsoref · 2022-04-18T23:35:16Z

tools/swift-inspect/Sources/swift-inspect/Backtrace.swift

-    return "\(hex: address) (\(module ?? "<uknown>")) \(symbol ??  "<unknown>")"
+    return "\(hex: address) (\(module ?? "<unknown>")) \(symbol ??  "<unknown>")"


jsoref · 2022-04-18T23:36:33Z

tools/SourceKit/cmake/modules/AddSwiftSourceKit.cmake

-function(add_sourcekitd_swifrt_linking target path HAS_SWIFT_MODULES)
+function(add_sourcekitd_swift_rt_linking target path HAS_SWIFT_MODULES)


jsoref commented Apr 18, 2022

View reviewed changes

jsoref marked this pull request as draft April 18, 2022 14:09

jsoref commented Apr 18, 2022

View reviewed changes

jsoref force-pushed the spelling branch from 6516e8a to 181eb69 Compare April 19, 2022 03:03

This was referenced Apr 19, 2022

Spelling docs #42437

Merged

Spelling changelog #42438

Merged

Spelling stdlib/public/runtime #42439

Merged

Spelling stdlib/public/core #42441

Merged

Spelling stdlib/public/concurrency #42443

Merged

Spelling stdlib #42444

Merged

jsoref closed this Apr 19, 2022

jsoref deleted the spelling branch April 19, 2022 18:18

jsoref restored the spelling branch April 19, 2022 18:19

jsoref reopened this Apr 19, 2022

		func hadWithdrawlOn(_ day: Date, from acct: BankAccount) async -> Bool {
		func hadWithdrawalOn(_ day: Date, from acct: BankAccount) async -> Bool {

		These functions change the control flow of a program in ways that that Swift
		These functions change the control flow of a program in ways that Swift

		[SE-0110]: <https://github.com/apple/swift-evolution/blob/main/proposals/0110-distingish-single-tuple-arg.md>
		[SE-0110]: <https://github.com/apple/swift-evolution/blob/main/proposals/0110-distinguish-single-tuple-arg.md>

		// locats before less favored ones.
		// locals before less favored ones.

		for [SE-0110: Distinguish between single-tuple and multiple-argument function types](https://github.com/apple/swift-evolution/blob/master/proposals/0110-distingish-single-tuple-arg.md).
		for [SE-0110: Distinguish between single-tuple and multiple-argument function types](https://github.com/apple/swift-evolution/blob/master/proposals/0110-distinguish-single-tuple-arg.md).

		// Why do we need to do this here (I just cargo culted this).
		// Why do we need to do this here (I just cargo-culted this).

		auto *reqrRerivativeId = requirementRef.getDerivativeFunctionIdentifier();
		auto *reqrDerivativeId = requirementRef.getDerivativeFunctionIdentifier();

		@@ -1184,10 +1184,10 @@ extension Unicode.Scalar.Properties {
		}

		// Used to potentially return a name who can either be represented in a large

		//===--- CompatibiltyOverride.h - Back-deploying compatibility fixes --- C++ --===//
		//===--- CompatibilityOverride.h - Back-deploying compatibility fixes --- C++ --===//

		// rdar://79757320 - failured to produce a diagnostic when unresolved dependent member is used in function result position
		// rdar://79757320 - failed to produce a diagnostic when unresolved dependent member is used in function result position

		_ = pair["strting"] // expected-error {{cannot access element using subscript for tuple type '(Int, Int)'; use '.' notation instead}} {{none}}
		_ = pair["string"] // expected-error {{cannot access element using subscript for tuple type '(Int, Int)'; use '.' notation instead}} {{none}}

		// -Onone reuses the existint lifetime-ending destroy.
		// -Onone reuses the existing lifetime-ending destroy.

		// allow exactly one unoptimzedkey path instruction, in this function
		// allow exactly one unoptimized key path instruction, in this function

		if let queuedAlertInfo = tabManager.selectedTab?.dequeueJavascriptAlertPrompt() {
		if let queuedAlertInfo = tabManager.selectedTab?.dequeueJavaScriptAlertPrompt() {

		hasOption = optionSet.find("-emit-modul") != optionSet.end();
		hasOption = optionSet.find("-emit-module") != optionSet.end();

		return "\(hex: address) (\(module ?? "<uknown>")) \(symbol ?? "<unknown>")"
		return "\(hex: address) (\(module ?? "<unknown>")) \(symbol ?? "<unknown>")"

		function(add_sourcekitd_swifrt_linking target path HAS_SWIFT_MODULES)
		function(add_sourcekitd_swift_rt_linking target path HAS_SWIFT_MODULES)

Spelling #42421

Are you sure you want to change the base?

Spelling #42421

Uh oh!

Conversation

jsoref commented Apr 18, 2022

Uh oh!

jsoref left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

CodaFi commented Apr 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CodaFi commented Apr 18, 2022

Uh oh!

jsoref commented Apr 18, 2022

Uh oh!

CodaFi commented Apr 18, 2022

Uh oh!

jsoref left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jsoref left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jsoref left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

CodaFi commented Apr 18, 2022 •

edited

Loading