Skip to content

Spelling sema #42474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 132 commits into from
Apr 20, 2022
Merged

Spelling sema #42474

merged 132 commits into from
Apr 20, 2022

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Apr 20, 2022

This fixes some misspellings in Swift documentation, it is split per #42421 (comment)

There's a bit of interaction between Sema and AST, so I've pulled a couple of changes out of the AST PR and into here.

jsoref added 30 commits April 19, 2022 23:55
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
jsoref added 18 commits April 20, 2022 00:18
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
@tshortli
Copy link
Contributor

@swift-ci please test

@AnthonyLatsis
Copy link
Collaborator

I wish CI could some day do these static checks for us.

@jsoref
Copy link
Contributor Author

jsoref commented Apr 20, 2022

Which "static checks"?

The tooling I'm using is available as a GitHub workflow 🙂.

@AnthonyLatsis
Copy link
Collaborator

AnthonyLatsis commented Apr 20, 2022

Typos, formatting, maybe mild stylistic enforcement and the like; the code base is moderately inconsistent in this sense, despite the conventions.

The tooling I'm using is available as a GitHub workflow 🙂.

I was referring to apple bots specifically.

@jsoref
Copy link
Contributor Author

jsoref commented Apr 20, 2022

Well, Jenkins can definitely respond to PRs and jobs/pipelines.

Can't tell if there's a policy your system has to reduce risk without first having some human decide a PR isn't malicious/spammy. (GitHub has recently added more bits to their environment because of such problems.)

@tshortli
Copy link
Contributor

Thank you, these changes all look reasonable to me. @CodaFi do you want to take a look as well?

@CodaFi CodaFi merged commit 4c77c59 into swiftlang:main Apr 20, 2022
@jsoref jsoref deleted the spelling-sema branch April 20, 2022 22:21
@AnthonyLatsis
Copy link
Collaborator

Well, Jenkins can definitely respond to PRs and jobs/pipelines.

It can be done of course. Though I doubt the community or us contributors have much of a say in this kind of stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants