Skip to content

🍒[5.7][Distributed] Guard ID synthesis from happening multiple times #42578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2022
Merged

🍒[5.7][Distributed] Guard ID synthesis from happening multiple times #42578

merged 2 commits into from
Apr 23, 2022

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented Apr 22, 2022

Description: Avoid synthesising the ID property many times in case of multi module builds.
Risk: Low
Review by: @DougGregor @kavon
Testing: Verified using sample app; unit tests
Original PR: #42577
Radar: rdar://92162535

@ktoso ktoso changed the base branch from main to release/5.7 April 22, 2022 14:26
@ktoso ktoso requested a review from a team as a code owner April 22, 2022 14:26
@ktoso
Copy link
Contributor Author

ktoso commented Apr 22, 2022

@swift-ci please test

@ktoso ktoso changed the title Pick prevent multiple id synthesis 5.7 🍒 [Distributed] Pick prevent multiple id synthesis Apr 22, 2022
@ktoso ktoso requested review from tomerd, xedin, kavon and DougGregor April 22, 2022 14:27
@ktoso ktoso changed the title 5.7 🍒 [Distributed] Pick prevent multiple id synthesis 🍒[5.7][Distributed] Pick prevent multiple id synthesis Apr 22, 2022
@ktoso ktoso added the distributed Feature → concurrency: distributed actor label Apr 22, 2022
@ktoso ktoso changed the title 🍒[5.7][Distributed] Pick prevent multiple id synthesis 🍒[5.7][Distributed] Guard ID synthesis from happening multiple times Apr 23, 2022
@ktoso
Copy link
Contributor Author

ktoso commented Apr 23, 2022

@xedin
Copy link
Contributor

xedin commented Apr 23, 2022

Not everything included in main has been cherry-picked to 5.7 so it might be something missing.

@ktoso ktoso added the r5.7 label Apr 23, 2022
@ktoso
Copy link
Contributor Author

ktoso commented Apr 23, 2022 •
edited
Loading

Yeah there's quite a few ~5 PRs waiting on 5.7, main and the other 5.7 branch have way more: https://github.com/apple/swift/pulls?q=is%3Apr+is%3Aopen+label%3ADistributed+draft%3Afalse+base%3A%22release%2F5.7%22+

So I'm thinking this is likely fixed since on 5.7-04182022 things seem good.
I'll re-run this once more stuff has landed.

@ktoso
Copy link
Contributor Author

ktoso commented Apr 23, 2022

@swift-ci please test

@ktoso ktoso merged commit 88c0a9e into swiftlang:release/5.7 Apr 23, 2022
@ktoso ktoso deleted the pick-prevent-multiple-id-synthesis branch April 23, 2022 11:24
@kavon
Copy link
Member

kavon commented Apr 26, 2022

nice catch!

@AnthonyLatsis AnthonyLatsis added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.7 labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomerd tomerd tomerd approved these changes

@DougGregor DougGregor DougGregor approved these changes

@xedin xedin Awaiting requested review from xedin

@kavon kavon Awaiting requested review from kavon

Assignees
No one assigned
Labels
distributed Feature → concurrency: distributed actor 🍒 release cherry pick Flag: Release branch cherry picks swift 5.7
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ktoso @xedin @kavon @tomerd @DougGregor @AnthonyLatsis