🍒[5.7-04182022][Distributed] Guard ID synthesis from happening multiple times #42579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ple times; e.g. during multi module builds
ktoso
changed the title
|
@swift-ci please test |
tomerd
approved these changes
Apr 22, 2022
DougGregor
approved these changes
Apr 22, 2022
ktoso
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Avoid synthesising the ID property many times in case of multi module builds. Without this declaring a distributed actor in separate files, in a multi module project, will cause a compiler crash. More detailed description on why that is in original ticket.
Risk: Low
Review by: @DougGregor @kavon
Testing: Verified using sample app; unit tests
Original PR: #42577
Radar: rdar://92162535