Switch override checking over to access scopes #4610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The class version of f65ad81. Fixes some incorrect diagnostics. We really do need https://bugs.swift.org/browse/SR-2209 to make this all cleaner. rdar://problem/27820665 (cherry picked from commit 8b1ce7d)
|
@swift-ci Please test |
This was referenced Sep 22, 2016
kateinoigakukun
added a commit
that referenced
this pull request
Aug 31, 2022
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Swift's access control restricts puts certain requirements on members that are overrides of members in the superclass. This logic hadn't been updated for SE-0025, resulting in incorrect and confusing diagnostics. (This is basically the override version of Check protocol witnesses using access scopes. #4176, which made a similar fix for protocol witnesses.)
There's an extra commit in here from @rintaro; that's mostly to make sure my change applies cleanly (their logic is all replaced), but also includes extra tests.
Scope: Affects all access checking for overrides.
Issue: rdar://problem/27820665
Reviewed by: @rjmccall
Risk: Medium. As has been pointed out this may break existing Swift 3 code that's doing something a little bit invalid that the old logic wasn't checking; I haven't tried to come up with such a case.
Testing: Added compiler regression tests, checked existing tests in this area.