Add empty parens to var-to-function renames. #4979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jrose-apple
commented
Sep 23, 2016
jrose-apple
commented
- Explanation: We have a fix-it for when a declaration is renamed, but that fix-it is mostly geared towards renames of functions to functions or properties to properties. When a property is replaced by a function, it would be nice™ if the fix-it added parens to call it. This change does that.
- Scope: Only affects diagnostics for deprecated or unavailable entities.
- Issue: SR-1649
- Reviewed by: @nkcsgexi and @harlanhaskins
- Risk: Low.
- Testing: Added existing compiler regression tests (most from an earlier version of this change).
This time, propagate the decl marked deprecated or unavailable through to the fix-it, so we can be sure it's a var. https://bugs.swift.org/browse/SR-1649 (cherry picked from commit d89c232)
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.