Skip to content

[stubs] Prevent CMake from linking with object lib #5096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

modocache
Copy link
Contributor

Attempting to link against an object library results in a CMake error. Prevent such an error by removing a line I mistakenly added in b86125a.

Attempting to link against an object library results in a CMake error.
Prevent such an error by removing a line I mistakenly added in b86125a.
@jrose-apple
Copy link
Contributor

jrose-apple commented Oct 3, 2016

Ah, is that where the Linux-only error we've been seeing came from? @shahmishal

@shahmishal
Copy link
Member

@jrose-apple Yes, looks like it.

@jrose-apple
Copy link
Contributor

@swift-ci Please test Linux platform

@jrose-apple
Copy link
Contributor

@swift-ci Please smoke test OS X platform

@modocache
Copy link
Contributor Author

Ah, is that where the Linux-only error we've been seeing came from?

Yes, my apologies! 🙇

@swift-ci
Copy link
Contributor

swift-ci commented Oct 3, 2016

Build failed
Jenkins build - Swift Test Linux Platform
Git Commit - 49248a4
Test requested by - @jrose-apple

@modocache
Copy link
Contributor Author

The test failure on Linux appears unrelated. More importantly, the Linux build of the runtime succeeded, which indicates the patch works as expected.

@jrose-apple
Copy link
Contributor

Yeah, we need to get this in. @swift-ci Please smoke test

@modocache
Copy link
Contributor Author

@jrose-apple Smoke test appears to have passed. Sorry again for the build break! 😞

@gottesmm
Copy link
Contributor

gottesmm commented Oct 4, 2016

@jrose-apple I am going to merge this since it passed the tests and you said it "needs to get in".

@gottesmm gottesmm merged commit 653eda7 into swiftlang:master Oct 4, 2016
@modocache modocache deleted the stdlib-stubs-cmake-fix-object-library-link branch October 4, 2016 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants