Skip to content

[SwiftShims] Improve CMake Clang headers error #5107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2016
Merged

[SwiftShims] Improve CMake Clang headers error #5107

merged 1 commit into from
Oct 4, 2016

Conversation

modocache
Copy link
Contributor

When Clang headers could not be found, print all the locations that were searched.

@modocache
[SwiftShims] Improve CMake Clang headers error
a6a072f 
When Clang headers could not be found, print all the locations that
were searched.
@jrose-apple
Copy link
Contributor

Seems reasonable to me.

@gottesmm
Copy link
Contributor

gottesmm commented Oct 3, 2016

LGTM. Feel free to merge.

@modocache
Copy link
Contributor Author

@swift-ci please test and merge

@gottesmm
Copy link
Contributor

gottesmm commented Oct 4, 2016

Now that #5096 is in... lets get this in.

@gottesmm
Copy link
Contributor

gottesmm commented Oct 4, 2016

@swift-ci Please smoke test linux platform

@gottesmm gottesmm merged commit 87329bf into swiftlang:master Oct 4, 2016
@modocache modocache deleted the swiftshims-clang-header-locations branch October 4, 2016 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gottesmm gottesmm

@jrose-apple jrose-apple

@llvm-beanz llvm-beanz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@modocache @jrose-apple @gottesmm @llvm-beanz