Fix exit bugs of multiple python scripts #546
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panzarino
changed the title
|
I'm trying to remember why I wrote fail.py rather than just hardcoding /usr/bin/false. |
The proper way to exit a python script is to use sys.exit not just exit
|
I just added some more python scripts that had the same problem |
|
#540 also fixes some of these. |
panzarino
changed the title
|
Replaced by #903 |
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
…er-on-error [Stress Tester XFails] Add new XFails found by continuing the stress tester on error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that the system uses
sys.exit(1)rather than justexit(1)becauseexit(1)should not be used in production.exit()should not be used in production code. This is because it only works if thesitemodule is loaded. Instead, this function should only be used in the interpreter.Unlike
exit()orquit()however,sys.exitis considered good to use in production code. This is because thesysmodule will always be there.