Fix exit bugs of some python scripts #903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still seems reasonable. Thanks, Zach! |
jrose-apple
added a commit
that referenced
this pull request
Jan 7, 2016
Fix exit bugs of some python scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that the system uses
sys.exit()rather than justexit()becauseexit()should not be used in production.exit()should not be used in production code. This is because it only works if thesitemodule is loaded. Instead, this function should only be used in the interpreter.Unlike
exit()orquit()however,sys.exit()is considered good to use in production code. This is because thesysmodule will always be there.Updates old PR: #546