Skip to content

[cmake]: Ensure that swift-api-digester rebuilds before tests are run. #5505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2016

Conversation

erg
Copy link
Contributor

@erg erg commented Oct 28, 2016

Running ninja check-swift didn't rebuild swift-api-digester.

Fixes rdar://problem/28953348

@erg
Copy link
Contributor Author

erg commented Oct 28, 2016

@swift-ci Please smoke test and merge

@nkcsgexi
Copy link
Contributor

Thank you! @erg

@swift-ci swift-ci merged commit 5a7604d into swiftlang:master Oct 28, 2016
@shahmishal
Copy link
Member

Linux bots failing due to

ninja: error: 'bin/swift-api-digester', needed by 'test/CMakeFiles/check-swift-validation-linux-x86_64', missing and no known rule to make it

https://ci.swift.org/job/oss-swift-incremental-RA-linux-ubuntu-16_04/421/consoleFull#-2088804878ee1a197b-acac-4b17-83cf-a53b95139a76

@erg
Copy link
Contributor Author

erg commented Oct 28, 2016

How did this get merged? The tests failed...

@shahmishal
Copy link
Member

build-script did not exit with non-zero after failing with ninja error.

Two bugs here:

  1. Build script should exit when sub command fails
  2. CMake change in this patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants