[cmake]: Second try at making swift-api-digester work correctly. #5512
Conversation
|
@swift-ci Please smoke test |
|
The problem is that swift-api-digester is only built on Apple platforms. (I mean, maybe we want to change that—cc @nkcsgexi—but for now I don't think we can just turn it on and expect things to work.) |
|
Can we exclusively build swift-api-digester on Apple platforms for now? |
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
|
swift-api-digester now builds on linux but the smoke test failed for other reasons. Try again.. |
| @@ -6,6 +6,7 @@ add_swift_tool_subdirectory(swift-demangle) | |||
| add_swift_tool_subdirectory(lldb-moduleimport-test) | |||
| add_swift_tool_subdirectory(sil-extract) | |||
| add_swift_tool_subdirectory(swift-llvm-opt) | |||
| add_swift_tool_subdirectory(swift-api-digester) | |||
|
|
|||
| if(SWIFT_HOST_VARIANT STREQUAL "macosx") | |||
| # Only build Darwin-specific tools when deploying to OS X. | |||
There was a problem hiding this comment.
If we are trying to build swift-api-digester for all platforms, please remove this section.
There was a problem hiding this comment.
Sorry, I missed this section. I see how my patch could be fixed for just OSX support, but is this something we want for Linux too?
Note: I ran into an issue compiling on Linux with STL 4.8 headers where STL vector needs an iterator instead of a ``const_iterator``. Hopefully this will not show on the CI machines. http://stackoverflow.com/questions/19559235/missing-const-iterator-overload-of-stdvectorerase-with-g-4-8
erg
force-pushed
the
fix-swift-api-digester2
branch
from
92e88ad to
fd36b92
Compare
|
Cleaned up the OSX special casing for swift-api-digester. |
|
@swift-ci Please smoke test |
…am/driver-wasm-toolchain Cherry-pick static-stdlib changes
Running ninja check-swift didn't rebuild swift-api-digester.
Previous: #5505
and: #5509
rdar://problem/28953348