[CodeCompletion] Offer suggestions if a nested type is followed by a same type requirement #58614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
rintaro
approved these changes
May 2, 2022
lib/Parse/ParseGeneric.cpp
Outdated
Comment on lines
364
to
365
| FirstType.get(), PreviousLoc, | ||
| new (Context) ErrorTypeRepr(PreviousLoc))); |
There was a problem hiding this comment.
It doesn't really matter, but I don't think we need to use fake locations.
Suggested change
| FirstType.get(), PreviousLoc, | |
| new (Context) ErrorTypeRepr(PreviousLoc))); | |
| FirstType.get(), EqualLoc, | |
| new (Context) ErrorTypeRepr(SecondType.getLoc()))); |
There was a problem hiding this comment.
Yes, you’re right. That’s what I got from copy-pasting the fake requirement from below.
… equal type requirement If the first type has a code completion token, don't record a same type constraint because otherwise if we have ```swift K.#^COMPLETE^# == Foo ``` we parse this as ``` K == Foo ``` and thus simplify `K` to `Foo`. But we didn't want to state that `K` is `Foo` but that `K` has a member of type `Foo`. rdar://77458518
ahoppen
force-pushed
the
pr/complete-type-with-same-type-requirement
branch
from
72c66d2 to
a35f185
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the first type has a code completion token, don't record a same type constraint because otherwise if we have
we parse this as
and thus simplify
KtoFoo. But we didn't want to state thatKisFoobut thatKhas a member of typeFoo.rdar://77458518