[5.7][CodeCompletion] Offer suggestions if a nested type is followed by a same type requirement #58657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… equal type requirement If the first type has a code completion token, don't record a same type constraint because otherwise if we have ```swift K.#^COMPLETE^# == Foo ``` we parse this as ``` K == Foo ``` and thus simplify `K` to `Foo`. But we didn't want to state that `K` is `Foo` but that `K` has a member of type `Foo`. rdar://77458518
ahoppen
changed the title
|
@swift-ci Please test |
airspeedswift
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #58614 to release/5.7.
==requirement, e.g.K.#^COMPLETE^# == Foo, we weren’t providing any results because we parsed it asK == Fooand thus were providing completion onFooinstead of the more generic typeK. Drop the== Foorequirement in these code completion cases to avoid the issue.== <some-type>requirement after the code completion token.