🍒[5.7-04182022][Distributed] Force the order of properties in AST #58748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
changed the title
|
@swift-ci please test |
missing type decl
ktoso
force-pushed
the
pick-pick-wip-init-crash-fix
branch
from
49b5776 to
fee52c6
Compare
|
Sigh... this patch fixed it properly on main but seems something else needs to be cherry picked to 5.7 for the fix to work on |
ktoso
force-pushed
the
pick-pick-wip-init-crash-fix
branch
from
2062aa9 to
de8486a
Compare
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please nominate |
DougGregor
approved these changes
May 10, 2022
…t will always be synthesized or present already
|
@swift-ci please test and merge |
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Summary:
Original PR: #58745
Radar:
Risk: Low, no impact on adopters
Details:
This is the actual solution for all our mystical offset issues -- the order of the synthesized AST fields MUST match the order IRGen enforces (and the DA needs in any case); where the id and system are the FIRST fields, and must be specifically: id, system because that's what IRGen emits and many places seem to expect the order matches between the original AST and whatever gets derived form it and IR.
This probably also resolves a few other crashers we had with similar crash reasons of weird mismatching offsets, I'll be verifying those.