[Distributed] revert too aggressive synthesis removal, and fix it instead #58752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
changed the title
|
@swift-ci please test and merge |
ktoso
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A disabled test (due to non-deterministic asan issues) missed to catch that this just removed in #58745 code path IS still necessary because other codepaths taken during multi module cases.
This brings back the previously removed synthesis, and instead, makes sure that when it happens we also synthesize in the expected order of the fields: id, actorSystem.
This will be picked right away into: #58747 and #58748 as they contained the too aggressive code removal.