Actually slice things in _StringGutsSlice (5.7 cherry pick) #58968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 9dd8d3a)
stephentyrone
approved these changes
May 18, 2022
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #58948
During the ICU removal we accidentally dropped checking the bounds on Substrings in some cases, particularly hashing. This resulted in Substrings that compared equal but hashed differently, causing crashes when using them as keys or putting them in sets. This change fixes that by slicing the temporary String we use to get access to the NFC data, and adds tests to make sure it stays fixed.
rdar://87371813
#59388
#59066