Skip to content

[Test] Do not load string processing when recovery is disabled #59087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2022

Conversation

bnbarham
Copy link
Contributor

This test specifically disables serialization recovery, but that can
cause issues when loading the experimental string processing library. We
don't use it in the test, so just disable it for now.

@bnbarham bnbarham requested a review from xymus May 25, 2022 22:43
@bnbarham
Copy link
Contributor Author

@swift-ci please test

@xymus
Copy link
Contributor

xymus commented May 25, 2022

I expect the string processing library to still be loaded indirectly in this case. Does indexing ignore indirect dependencies?

This test specifically disables serialization recovery, but that can
cause issues when loading the experimental string processing library. We
don't use it in the test, so just disable it for now.
@bnbarham
Copy link
Contributor Author

@swift-ci please smoke test

@bnbarham
Copy link
Contributor Author

I expect the string processing library to still be loaded indirectly in this case. Does indexing ignore indirect dependencies?

Ah, thanks. I've disabled in lib/lib2 as well.

@bnbarham
Copy link
Contributor Author

@swift-ci please smoke test macOS platform

@bnbarham
Copy link
Contributor Author

@swift-ci please smoke test

@xymus xymus merged commit 84c547a into swiftlang:main May 26, 2022
@bnbarham bnbarham deleted the fix-test branch May 26, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants