Skip to content

[5.7][Test] Do not load string processing when recovery is disabled #59088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2022

Conversation

bnbarham
Copy link
Contributor

Cherry-picks aa93af2 (#59087) to avoid a potential erroneous test failure.


This test specifically disables serialization recovery, but that can
cause issues when loading the experimental string processing library. We
don't use it in the test, so just disable it for now.

@bnbarham bnbarham requested review from xymus and airspeedswift May 25, 2022 22:44
@bnbarham bnbarham requested a review from a team as a code owner May 25, 2022 22:44
@bnbarham
Copy link
Contributor Author

@swift-ci please test

This test specifically disables serialization recovery, but that can
cause issues when loading the experimental string processing library. We
don't use it in the test, so just disable it for now.
@bnbarham bnbarham changed the title [Test] Do not load string processing when recovery is disabled [5.7][Test] Do not load string processing when recovery is disabled May 26, 2022
@bnbarham bnbarham added the r5.7 label May 26, 2022
@bnbarham
Copy link
Contributor Author

@swift-ci please test

@bnbarham
Copy link
Contributor Author

@swift-ci please smoke test macOS platform

@xymus
Copy link
Contributor

xymus commented May 26, 2022

@swift-ci please test macOS platform

@bnbarham
Copy link
Contributor Author

@swift-ci please smoke test

@xymus xymus merged commit a00d319 into swiftlang:release/5.7 May 26, 2022
@bnbarham bnbarham deleted the cherry-fix-test branch May 26, 2022 20:42
@AnthonyLatsis AnthonyLatsis added 🍒 release cherry pick Flag: Release branch cherry picks swift 5.7 labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 5.7
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants