Disallow async IBAction methods #59205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
NSAntoine
reviewed
Jun 1, 2022
beccadax
requested changes
Jun 1, 2022
The IBAction signature does not allow completion handlers, so making IBAction methods async doesn't make sense. Disallowing it statically so it doesn't just break people when they try.
This patch merges the two diagnostics complaining about asynchronous function declarations with incompatible attributes. The two are cdecl and ibaction at the moment.
This adds a note with a possible way to fix the issue, recommending removing the `async` effect and wrapping the body of the function in a task.
etcwilde
force-pushed
the
ewilde/no-async-ibactions
branch
from
d7a97ac to
103fca9
Compare
|
@swift-ci please test |
This patch teaches the compiler to emit a fix-it to automatically wrap everything in the function in a Task and remove the effects from the function declaration.
etcwilde
force-pushed
the
ewilde/no-async-ibactions
branch
from
103fca9 to
129b9c0
Compare
|
@swift-ci please test |
|
@swift-ci please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IBAction signature does not allow completion handlers, so making
IBAction methods async doesn't make sense. Disallowing it statically so
it doesn't just break people when they try.
Resolves: rdar://83259194