🍒[5.7] Disallow async IBAction Methods #60392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IBAction signature does not allow completion handlers, so making IBAction methods async doesn't make sense. Disallowing it statically so it doesn't just break people when they try. This adds a note with a possible fix + fix-it for the issue, recommending removing the `async` and wrapping the body of the function in a task.
|
@swift-ci please test |
|
@swift-ci please nominate |
airspeedswift
approved these changes
Aug 4, 2022
AnthonyLatsis
added
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IBAction signature does not allow completion handlers, so making
IBAction methods async doesn't make sense. Disallowing it statically so
it doesn't just break people when they try.
This adds a note with a possible fix + fix-it for the issue,
recommending removing the
asyncand wrapping the body of the functionin a task.
The end result is that the app crashing at runtime is caught at compile time.
Risk: Low
Review by: @beccadax
Testing: PR testing, additional test cases, local testing
Original PR: #59205
Radar: rdar://83259194